2016-06-15 14:51:17

by Eduardo Abinader

Subject: [PATCH] ath9k: return false when reading wrong eeprom offset

Just setting the proper return for reading beyond the
eeprom data.

Signed-off-by: Eduardo Abinader <[email protected]>
---
drivers/net/wireless/ath/ath9k/pci.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/net/wireless/ath/ath9k/pci.c
b/drivers/net/wireless/ath/ath9k/pci.c
index 7cdaf40..aa04b13 100644
--- a/drivers/net/wireless/ath/ath9k/pci.c
+++ b/drivers/net/wireless/ath/ath9k/pci.c
@@ -794,6 +794,8 @@ static bool ath_pci_eeprom_read(struct ath_common
*common, u32 off, u16 *data)
ath_err(common,
"%s: eeprom read failed, offset %08x is out of range\n",
__func__, off);
+
+ return false;
}

*data = pdata->eeprom_data[off];
--
2.5.0

2016-06-16 16:06:33

by Kalle Valo

Subject: Re: [PATCH] ath9k: return false when reading wrong eeprom offset

Eduardo Abinader <[email protected]> writes:

> Just setting the proper return for reading beyond the
> eeprom data.
>
> Signed-off-by: Eduardo Abinader <[email protected]>
> ---
> drivers/net/wireless/ath/ath9k/pci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/wireless/ath/ath9k/pci.c
> b/drivers/net/wireless/ath/ath9k/pci.c
> index 7cdaf40..aa04b13 100644

The patch is corrupted, most likely due to an extra newline. Please
resend.

Applying: ath9k: return false when reading wrong eeprom offset
fatal: corrupt patch at line 14
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 ath9k: return false when reading wrong eeprom offset

--
Kalle Valo