2017-12-07 10:20:51

by Colin King

Subject: [PATCH] brcmsmac: use ARRAY_SIZE on rfseq_updategainu_events

From: Colin Ian King <[email protected]>

Use the ARRAY_SIZE macro on rfseq_updategainu_events to determine
size of the array. Improvement suggested by coccinelle.

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c
index 763e8ba6b178..7e01981bc5c8 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c
@@ -16049,8 +16049,7 @@ static void wlc_phy_workarounds_nphy_gainctrl(struct brcms_phy *pi)
wlc_phy_set_rfseq_nphy(pi, NPHY_RFSEQ_UPDATEGAINU,
rfseq_updategainu_events,
rfseq_updategainu_dlys,
- sizeof(rfseq_updategainu_events) /
- sizeof(rfseq_updategainu_events[0]));
+ ARRAY_SIZE(rfseq_updategainu_events));

mod_phy_reg(pi, 0x153, (0xff << 8), (90 << 8));

--
2.14.1

2017-12-14 12:40:33

by Kalle Valo

Subject: Re: brcmsmac: use ARRAY_SIZE on rfseq_updategainu_events

Colin Ian King <[email protected]> wrote:

> From: Colin Ian King <[email protected]>
>
> Use the ARRAY_SIZE macro on rfseq_updategainu_events to determine
> size of the array. Improvement suggested by coccinelle.
>
> Signed-off-by: Colin Ian King <[email protected]>
> Acked-by: Arend van Spriel <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

18907f20ea71 brcmsmac: use ARRAY_SIZE on rfseq_updategainu_events

--
https://patchwork.kernel.org/patch/10098257/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2017-12-07 10:30:19

by Arend Van Spriel

Subject: Re: [PATCH] brcmsmac: use ARRAY_SIZE on rfseq_updategainu_events

On 12/7/2017 11:20 AM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Use the ARRAY_SIZE macro on rfseq_updategainu_events to determine
> size of the array. Improvement suggested by coccinelle.

Acked-by: Arend van Spriel <[email protected]>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)