2018-08-15 11:58:24

by Chi-Hsien Lin

[permalink] [raw]
Subject: [PATCH] Add CYW89342 mini-PCIe device

From: Jia-Shyr Chuang <[email protected]>

CYW89342 is a 2x2 MIMO, 802.11a/b/g/n/ac, SDIO 3.0 and PCIe 3.0 for
WLAN. It is a member of 4355/4359 family.

Signed-off-by: Jia-Shyr Chuang <[email protected]>
Signed-off-by: Chi-Hsien Lin <[email protected]>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
index 45928b5b8d97..f787ee5a6b6a 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c
@@ -2016,6 +2016,7 @@ static const struct dev_pm_ops brcmf_pciedrvr_pm = {

static const struct pci_device_id brcmf_pcie_devid_table[] = {
BRCMF_PCIE_DEVICE(BRCM_PCIE_4350_DEVICE_ID),
+ BRCMF_PCIE_DEVICE_SUB(0x4355, BRCM_PCIE_VENDOR_ID_BROADCOM, 0x4355),
BRCMF_PCIE_DEVICE(BRCM_PCIE_4356_DEVICE_ID),
BRCMF_PCIE_DEVICE(BRCM_PCIE_43567_DEVICE_ID),
BRCMF_PCIE_DEVICE(BRCM_PCIE_43570_DEVICE_ID),
--
2.1.0


2018-08-15 12:21:28

by Chi-Hsien Lin

[permalink] [raw]
Subject: Re: [PATCH] Add CYW89342 mini-PCIe device



On 08/15/2018 5:16, Arend van Spriel wrote:
> O, and add "brcmfmac:" prefix in the subject.
Arend,

Thanks a lot for the feedback. Fixed below in V3:
- Add "brcmfmac:" prefix
- Remove host interface references from commit message.

Regards,
Chi-hsien Lin


>
> Regards,
> Arend
>
>
> ----------
>
> You're receiving this message because you're a member of the
> brcm80211-dev-list group.
> .
>

2018-08-15 12:07:46

by Arend Van Spriel

[permalink] [raw]
Subject: Re: [PATCH] Add CYW89342 mini-PCIe device

O, and add "brcmfmac:" prefix in the subject.

Regards,
Arend

2018-08-15 12:06:23

by Arend Van Spriel

[permalink] [raw]
Subject: Re: [PATCH] Add CYW89342 mini-PCIe device

On 8/15/2018 11:06 AM, Chi-Hsien Lin wrote:
> From: Jia-Shyr Chuang <[email protected]>
>
> CYW89342 is a 2x2 MIMO, 802.11a/b/g/n/ac, SDIO 3.0 and PCIe 3.0 for
> WLAN. It is a member of 4355/4359 family.

So the device support SDIO, but this patch only adds the PCIe variant.
The subject mentions that already, but mentioning SDIO in the commit
message may confuse people. I would just drop the host interface
references, ie. SDIO and PCIe from the commit message.

Regards,
Arend

> Signed-off-by: Jia-Shyr Chuang <[email protected]>
> Signed-off-by: Chi-Hsien Lin <[email protected]>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 1 +
> 1 file changed, 1 insertion(+)