2023-09-20 15:05:16

by Kalle Valo

Subject: Re: [PATCH v2 wireless-next 7/9] wifi: ath12k: Remove unnecessary (void*) conversions

Wu Yunchuan <[email protected]> wrote:

> No need cast (void*) to (struct hal_rx_ppdu_end_user_stats *),
> (struct ath12k_rx_desc_info *) or (struct hal_tx_msdu_ext_desc *).
> Change the prototype to remove the local variable.
>
> Signed-off-by: Wu Yunchuan <[email protected]>
> Suggested-by: Jeff Johnson <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

This added new warnings:

drivers/net/wireless/ath/ath12k/dp_mon.c:25: line length of 92 exceeds 90 columns
drivers/net/wireless/ath/ath12k/dp_mon.c:26: line length of 95 exceeds 90 columns

I fixed them in the pending branch by renaming ppdu_end_user to stats and
moving rx_user_status to it's own line:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=5c0910fdf1d800f1aeb8ab3e860e61bebec0091b

No need to resend because of this.

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2023-09-20 19:09:12

by Jeff Johnson

Subject: Re: [PATCH v2 wireless-next 7/9] wifi: ath12k: Remove unnecessary (void*) conversions

On 9/20/2023 7:52 AM, Kalle Valo wrote:
> Wu Yunchuan <[email protected]> wrote:
>
>> No need cast (void*) to (struct hal_rx_ppdu_end_user_stats *),
>> (struct ath12k_rx_desc_info *) or (struct hal_tx_msdu_ext_desc *).
>> Change the prototype to remove the local variable.
>>
>> Signed-off-by: Wu Yunchuan <[email protected]>
>> Suggested-by: Jeff Johnson <[email protected]>
>> Signed-off-by: Kalle Valo <[email protected]>

For the Pending change:
Acked-by: Jeff Johnson <[email protected]>