2019-01-24 07:54:47

by Jan Kiszka

Subject: [PATCH] arm64: dts: zcu100-revC: Give wifi some time after power-on

From: Jan Kiszka <[email protected]>

Somewhere along recent changes to power control of the wl1835, power-on
became very unreliable on the hikey, failing like this:

wl1271_sdio: probe of mmc2:0001:1 failed with error -16
wl1271_sdio: probe of mmc2:0001:2 failed with error -16

After playing with some dt parameters and comparing to other users of
this chip, it turned out we need some power-on delay to make things
stable again. In contrast to those other users which define 200 ms,
Ultra96 is already happy with 10 ms.

Fixes: ea452678734e ("arm64: dts: hikey: Fix WiFi support")
Signed-off-by: Jan Kiszka <[email protected]>
Acked-by: Ulf Hansson <[email protected]>
---
arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
index 13a0a028df98..e5699d0d91e4 100644
--- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
+++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
@@ -101,6 +101,7 @@
sdio_pwrseq: sdio-pwrseq {
compatible = "mmc-pwrseq-simple";
reset-gpios = <&gpio 7 GPIO_ACTIVE_LOW>; /* WIFI_EN */
+ post-power-on-delay-ms = <10>;
};
};

--
2.16.4

2019-01-24 08:26:16

by Ulf Hansson

Subject: Re: [PATCH] arm64: dts: zcu100-revC: Give wifi some time after power-on

On Thu, 24 Jan 2019 at 08:54, Jan Kiszka <[email protected]> wrote:
>
> From: Jan Kiszka <[email protected]>
>
> Somewhere along recent changes to power control of the wl1835, power-on
> became very unreliable on the hikey, failing like this:
>
> wl1271_sdio: probe of mmc2:0001:1 failed with error -16
> wl1271_sdio: probe of mmc2:0001:2 failed with error -16
>
> After playing with some dt parameters and comparing to other users of
> this chip, it turned out we need some power-on delay to make things
> stable again. In contrast to those other users which define 200 ms,
> Ultra96 is already happy with 10 ms.

This changelog is talking about Hikey, while you do a fix a for the
zynqmp platform. Please rewords this accordingly.

>
> Fixes: ea452678734e ("arm64: dts: hikey: Fix WiFi support")

This is not the correct commit. Please change to:

Fixes: 5869ba0653b9 ("arm64: zynqmp: Add support for Xilinx zcu100-revC")

> Signed-off-by: Jan Kiszka <[email protected]>
> Acked-by: Ulf Hansson <[email protected]>
> ---
> arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> index 13a0a028df98..e5699d0d91e4 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> @@ -101,6 +101,7 @@
> sdio_pwrseq: sdio-pwrseq {
> compatible = "mmc-pwrseq-simple";
> reset-gpios = <&gpio 7 GPIO_ACTIVE_LOW>; /* WIFI_EN */
> + post-power-on-delay-ms = <10>;
> };
> };

Kind regards
Uffe