2019-01-07 14:43:16

by Július Milan

Subject: [PATCH v4] staging: wilc1000: fix registration frame size

Fixes the following sparse warnings:

drivers/staging/wilc1000/host_interface.c:2360:30: warning:
incorrect type in assignment (different base types)
expected restricted __le32 [addressable] [assigned] [usertype] frame_type
got restricted __le16 [usertype] <noident>

Fixes: 147ccfd451024 ("staging: wilc1000: handle mgmt_frame_register ops from cfg82011 context")
Signed-off-by: J?lius Milan <[email protected]>
---
drivers/staging/wilc1000/host_interface.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

v3:
- nothing really changed since v1, v2, I just messed emails and then patch
format, sorry for that, it's my first patch :)

v4:
- changed struct wilc_reg_frame member frame_type type to le16
- reverted cast of frame_type to le32 in wilc_frame_register
- changed subject line, previous version has subject:
"[PATCH v3] staging: wilc1000: fix cast to restricted __le32"
https://www.spinics.net/lists/linux-wireless/msg181166.html

diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
index 70c854d939ce..7acb790d850b 100644
--- a/drivers/staging/wilc1000/host_interface.c
+++ b/drivers/staging/wilc1000/host_interface.c
@@ -36,7 +36,7 @@ struct wilc_op_mode {
struct wilc_reg_frame {
bool reg;
u8 reg_id;
- __le32 frame_type;
+ __le16 frame_type;
} __packed;

struct wilc_drv_handler {
--
2.14.5

2019-01-08 02:52:56

by Ajay Singh

Subject: Re: [PATCH v4] staging: wilc1000: fix registration frame size

On 1/7/2019 8:13 PM, Július Milan wrote:
> Fixes the following sparse warnings:
>
> drivers/staging/wilc1000/host_interface.c:2360:30: warning:
> incorrect type in assignment (different base types)
> expected restricted __le32 [addressable] [assigned] [usertype] frame_type
> got restricted __le16 [usertype] <noident>
>
> Fixes: 147ccfd451024 ("staging: wilc1000: handle mgmt_frame_register ops from cfg82011 context")
> Signed-off-by: Július Milan <[email protected]>

Thanks, the change looks fine to me.

Reviewed-by: Ajay Singh <[email protected]>

Regards,
Ajay