2017-04-26 09:00:40

by Arend Van Spriel

[permalink] [raw]
Subject: Re: ath6kl: assure headroom of skbuff is writable in .start_xmit()

On 4/26/2017 10:53 AM, Kalle Valo wrote:
> Arend Van Spriel <[email protected]> wrote:
>> An issue was found brcmfmac driver in which a skbuff in .start_xmit()
>> callback was actually cloned. So instead of checking for sufficient
>> headroom it should also be writable. Hence use skb_cow_head() to
>> check and expand the headroom appropriately.
>>
>> Signed-off-by: Arend van Spriel <[email protected]>
>
> Steve, would you have time to run a quick test with this?
>
> Patch set to Deferred.

Just a hint. I tested the equivalent patch in brcmfmac by doing a
skb_clone() just before the headroom if-statement (and a kfree_skb()
afterwards obviously ;-) ).

Regards,
Arend