On 8/14/2023 12:32 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> This has never been used since the driver was merged, but it now causes
> a W=1 warning in recent clang versions
>
> drivers/net/wireless/ath/ath9k/main.c:1566:21: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter]
> drivers/net/wireless/ath/ath9k/htc_drv_main.c:1258:25: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter]
> drivers/net/wireless/ath/ath5k/mac80211-ops.c:367:62: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter]
>
> Remove the bit manipulation on the otherwise unused parameter.
>
> Signed-off-by: Arnd Bergmann <[email protected]>
I'm wondering if the ath12k change should be separated into its own
patch because 1) it is the most current driver with a dedicated list,
and 2) it actually doesn't generate a warning because changed_flags is
used, just not in a meaningful way. But I'll let Kalle make the call on
that when he returns from holiday.
Reviewed-by: Jeff Johnson <[email protected]>