2023-07-19 10:01:34

by hanyu001

Subject: [PATCH] rtlwifi: rtl8192de: phy: "foo * bar" should be "foo *bar"

This patch fixes the checkpatch.pl error:

./drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c:2434: ERROR: "foo
* bar" should be "foo *bar"

Signed-off-by: Yu Han <[email protected]>
---
drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
index d18c092..27b029b 100644
--- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
+++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
@@ -2431,7 +2431,7 @@ static bool _rtl92d_is_legal_5g_channel(struct
ieee80211_hw *hw, u8 channel)
}

static void _rtl92d_phy_calc_curvindex(struct ieee80211_hw *hw,
- u32 *targetchnl, u32 * curvecount_val,
+ u32 *targetchnl, u32 *curvecount_val,
bool is5g, u32 *curveindex)
{
struct rtl_priv *rtlpriv = rtl_priv(hw);

2023-07-19 13:31:05

by Larry Finger

Subject: Re: [PATCH] rtlwifi: rtl8192de: phy: "foo * bar" should be "foo *bar"

On 7/19/23 04:54, [email protected] wrote:
>
> This patch fixes the checkpatch.pl error:
>
> ./drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c:2434: ERROR: "foo * bar"
> should be "foo *bar"
>
> Signed-off-by: Yu Han <[email protected]>
> ---
>  drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> index d18c092..27b029b 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> @@ -2431,7 +2431,7 @@ static bool _rtl92d_is_legal_5g_channel(struct
> ieee80211_hw *hw, u8 channel)
>  }
>
>  static void _rtl92d_phy_calc_curvindex(struct ieee80211_hw *hw,
> -                       u32 *targetchnl, u32 * curvecount_val,
> +                       u32 *targetchnl, u32 *curvecount_val,
>                         bool is5g, u32 *curveindex)
>  {
>      struct rtl_priv *rtlpriv = rtl_priv(hw);

The preferred subject would be "wifi: rtlwifi: rtl8192de: ...." That can
probably be fixed at merge time. I will let Kalle decide that part.

Reviewed-by: Larry Finger<[email protected]>

Thanks,

Larry

2023-07-24 14:41:33

by Kalle Valo

Subject: Re: [PATCH] rtlwifi: rtl8192de: phy: "foo * bar" should be "foo *bar"

[email protected] writes:

> This patch fixes the checkpatch.pl error:
>
> ./drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c:2434: ERROR:
> "foo * bar" should be "foo *bar"
>
> Signed-off-by: Yu Han <[email protected]>

Please don't submit checkpatch fixes to wireless, they are too much work
with very little gain.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches