2016-05-17 23:02:15

by Heinrich Schuchardt

Subject: [PATCH 1/1] mwifiex: illegal assignment

Variable adapter is incorrectly initialized.

Fixes: bf00dc22bc7a ("mwifiex: AMSDU Rx frame handling in AP mode")
Signed-off-by: Heinrich Schuchardt <[email protected]>
---
drivers/net/wireless/marvell/mwifiex/uap_txrx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/marvell/mwifiex/uap_txrx.c b/drivers/net/wireless/marvell/mwifiex/uap_txrx.c
index 666e91a..bf5660e 100644
--- a/drivers/net/wireless/marvell/mwifiex/uap_txrx.c
+++ b/drivers/net/wireless/marvell/mwifiex/uap_txrx.c
@@ -272,7 +272,7 @@ int mwifiex_handle_uap_rx_forward(struct mwifiex_private *priv,
int mwifiex_uap_recv_packet(struct mwifiex_private *priv,
struct sk_buff *skb)
{
- struct mwifiex_adapter *adapter = adapter;
+ struct mwifiex_adapter *adapter = priv->adapter;
struct mwifiex_sta_node *src_node;
struct ethhdr *p_ethhdr;
struct sk_buff *skb_uap;
--
2.1.4

2016-06-14 14:19:55

by Kalle Valo

Subject: Re: [1/1] mwifiex: illegal assignment

Heinrich Schuchardt <[email protected]> wrote:
> Variable adapter is incorrectly initialized.
>
> Fixes: bf00dc22bc7a ("mwifiex: AMSDU Rx frame handling in AP mode")
> Signed-off-by: Heinrich Schuchardt <[email protected]>
> Acked-by: Amitkumar Karwar <[email protected]>

Thanks, 1 patch applied to wireless-drivers-next.git:

3fdbda446fbc mwifiex: illegal assignment

--
Sent by pwcli
https://patchwork.kernel.org/patch/9115501/

2016-06-09 13:22:17

by Amitkumar Karwar

Subject: RE: [PATCH 1/1] mwifiex: illegal assignment

> From: Heinrich Schuchardt [mailto:[email protected]]
> Sent: Wednesday, May 18, 2016 4:32 AM
> To: Amitkumar Karwar; Nishant Sarmukadam; Kalle Valo
> Cc: Xinming Hu; Cathy Luo; [email protected];
> [email protected]; [email protected]; Heinrich
> Schuchardt
> Subject: [PATCH 1/1] mwifiex: illegal assignment
>
> Variable adapter is incorrectly initialized.
>
> Fixes: bf00dc22bc7a ("mwifiex: AMSDU Rx frame handling in AP mode")
> Signed-off-by: Heinrich Schuchardt <[email protected]>
> ---
> drivers/net/wireless/marvell/mwifiex/uap_txrx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/marvell/mwifiex/uap_txrx.c
> b/drivers/net/wireless/marvell/mwifiex/uap_txrx.c
> index 666e91a..bf5660e 100644
> --- a/drivers/net/wireless/marvell/mwifiex/uap_txrx.c
> +++ b/drivers/net/wireless/marvell/mwifiex/uap_txrx.c
> @@ -272,7 +272,7 @@ int mwifiex_handle_uap_rx_forward(struct
> mwifiex_private *priv, int mwifiex_uap_recv_packet(struct
> mwifiex_private *priv,
> struct sk_buff *skb)
> {
> - struct mwifiex_adapter *adapter = adapter;
> + struct mwifiex_adapter *adapter = priv->adapter;
> struct mwifiex_sta_node *src_node;
> struct ethhdr *p_ethhdr;
> struct sk_buff *skb_uap;
> --
> 2.1.4

Acked-by: Amitkumar Karwar <[email protected]>

Regards,
Amitkumar