2017-08-23 19:33:09

by Erik Stromdahl

Subject: [PATCH v2] ath10k: sdio: remove unused struct member

irq_wq in struct ath10k_sdio is a remnant from an earlier
version of the sdio patchset.

Its use was removed as a result of Kalle's review, but somehow
the struct member survived.

It is not used and can therefore safely be removed.

Signed-off-by: Erik Stromdahl <[email protected]>
---
V2: Fix typo in commit log (It's -> Its)
---
drivers/net/wireless/ath/ath10k/sdio.c | 4 ----
drivers/net/wireless/ath/ath10k/sdio.h | 2 --
2 files changed, 6 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/sdio.c b/drivers/net/wireless/ath/ath10k/sdio.c
index 48268f0..03a69e5 100644
--- a/drivers/net/wireless/ath/ath10k/sdio.c
+++ b/drivers/net/wireless/ath/ath10k/sdio.c
@@ -1344,8 +1344,6 @@ static void ath10k_sdio_irq_handler(struct sdio_func *func)

sdio_claim_host(ar_sdio->func);

- wake_up(&ar_sdio->irq_wq);
-
if (ret && ret != -ECANCELED)
ath10k_warn(ar, "failed to process pending SDIO interrupts: %d\n",
ret);
@@ -2000,8 +1998,6 @@ static int ath10k_sdio_probe(struct sdio_func *func,
goto err_free_bmi_buf;
}

- init_waitqueue_head(&ar_sdio->irq_wq);
-
for (i = 0; i < ATH10K_SDIO_BUS_REQUEST_MAX_NUM; i++)
ath10k_sdio_free_bus_req(ar, &ar_sdio->bus_req[i]);

diff --git a/drivers/net/wireless/ath/ath10k/sdio.h b/drivers/net/wireless/ath/ath10k/sdio.h
index 3f61c67..4ff7b54 100644
--- a/drivers/net/wireless/ath/ath10k/sdio.h
+++ b/drivers/net/wireless/ath/ath10k/sdio.h
@@ -210,8 +210,6 @@ struct ath10k_sdio {
/* temporary buffer for BMI requests */
u8 *bmi_buf;

- wait_queue_head_t irq_wq;
-
bool is_disabled;

struct workqueue_struct *workqueue;
--
2.7.4

2017-08-31 12:14:47

by Kalle Valo

Subject: Re: [v2] ath10k: sdio: remove unused struct member

Erik Stromdahl <[email protected]> wrote:

> irq_wq in struct ath10k_sdio is a remnant from an earlier
> version of the sdio patchset.
>
> Its use was removed as a result of Kalle's review, but somehow
> the struct member survived.
>
> It is not used and can therefore safely be removed.
>
> Signed-off-by: Erik Stromdahl <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

30b83fff6d97 ath10k: sdio: remove unused struct member

--
https://patchwork.kernel.org/patch/9918195/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches