2008-11-12 00:32:57

by Luis R. Rodriguez

[permalink] [raw]
Subject: libertas_tf should replace libertas_usb on compat-wireless?

By default do we want users of compat-wireless to get libertas_usb or
libertas_tf? Both drivers are for Marvell Libertas 8388 USB 802.11b/g
cards so we need to pick one.

Luis


2008-11-12 21:16:38

by Gábor Stefanik

[permalink] [raw]
Subject: Re: libertas_tf should replace libertas_usb on compat-wireless?

On Wed, Nov 12, 2008 at 10:07 PM, Andrey Yurovsky <[email protected]> wrote:
> libertas_tf is a softmac driver developed mainly so that XO's can run
> hostapd and the like. libertas is the general (fullmac) driver and,
> in my opinion, should be the one users get unless they specifically
> wanted libertas_tf because they're experimenting with AP mode or other
> mac80211 features. So I guess I'd vote for libertas over libertas_tf
> at this time, for what it's worth.
>
> -Andrey

I think libertas_usb should be a default (as it's HW accelerated), but
libertas_tf should be included as an option (disabled by default in
config.mk, or auto-added to /etc/modprobe.d/blacklist upon make
install).

--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)

2008-11-12 22:28:00

by Luis R. Rodriguez

[permalink] [raw]
Subject: Re: libertas_tf should replace libertas_usb on compat-wireless?

On Wed, Nov 12, 2008 at 01:16:36PM -0800, Stefanik G=E1bor wrote:
> On Wed, Nov 12, 2008 at 10:07 PM, Andrey Yurovsky <[email protected]=
> wrote:
> > libertas_tf is a softmac driver developed mainly so that XO's can r=
un
> > hostapd and the like. libertas is the general (fullmac) driver and=
,
> > in my opinion, should be the one users get unless they specifically
> > wanted libertas_tf because they're experimenting with AP mode or ot=
her
> > mac80211 features. So I guess I'd vote for libertas over libertas_=
tf
> > at this time, for what it's worth.
> >
> > -Andrey
>=20
> I think libertas_usb should be a default (as it's HW accelerated), bu=
t
> libertas_tf should be included as an option (disabled by default in
> config.mk, or auto-added to /etc/modprobe.d/blacklist upon make
> install).

OK so I've done this on config.mk:

ifneq ($(CONFIG_USB),)
ifneq ($(CONFIG_LIBERTAS_THINFIRM_USB),m)
CONFIG_LIBERTAS_USB=3Dm
NEED_LIBERTAS=3Dy
endif
endif

This means you'll get CONFIG_LIBERTAS_USB unless your kernel
already was built with CONFIG_LIBERTAS_THINFIRM_USB for all those
building with it. If your kernel was built with both then its your
problem.

Luis

2008-11-12 22:29:28

by Gábor Stefanik

[permalink] [raw]
Subject: Re: libertas_tf should replace libertas_usb on compat-wireless?

On Wed, Nov 12, 2008 at 11:27 PM, Luis R. Rodriguez
<[email protected]> wrote:
> On Wed, Nov 12, 2008 at 01:16:36PM -0800, Stefanik G=E1bor wrote:
>> On Wed, Nov 12, 2008 at 10:07 PM, Andrey Yurovsky <[email protected]=
m> wrote:
>> > libertas_tf is a softmac driver developed mainly so that XO's can =
run
>> > hostapd and the like. libertas is the general (fullmac) driver an=
d,
>> > in my opinion, should be the one users get unless they specificall=
y
>> > wanted libertas_tf because they're experimenting with AP mode or o=
ther
>> > mac80211 features. So I guess I'd vote for libertas over libertas=
_tf
>> > at this time, for what it's worth.
>> >
>> > -Andrey
>>
>> I think libertas_usb should be a default (as it's HW accelerated), b=
ut
>> libertas_tf should be included as an option (disabled by default in
>> config.mk, or auto-added to /etc/modprobe.d/blacklist upon make
>> install).
>
> OK so I've done this on config.mk:
>
> ifneq ($(CONFIG_USB),)
> ifneq ($(CONFIG_LIBERTAS_THINFIRM_USB),m)
> CONFIG_LIBERTAS_USB=3Dm
> NEED_LIBERTAS=3Dy
> endif
> endif
>
> This means you'll get CONFIG_LIBERTAS_USB unless your kernel
> already was built with CONFIG_LIBERTAS_THINFIRM_USB for all those
> building with it. If your kernel was built with both then its your
> problem.
>
> Luis
>

If the kernel has both, compat-wireless should also build both.

--=20
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)

2008-11-12 19:55:17

by Luis R. Rodriguez

[permalink] [raw]
Subject: Re: libertas_tf should replace libertas_usb on compat-wireless?

On Wed, Nov 12, 2008 at 09:57:29AM -0800, Dan Williams wrote:
> On Wed, 2008-11-12 at 10:53 -0500, Dan Williams wrote:
> > On Tue, 2008-11-11 at 16:32 -0800, Luis R. Rodriguez wrote:
> > > By default do we want users of compat-wireless to get libertas_usb or
> > > libertas_tf? Both drivers are for Marvell Libertas 8388 USB 802.11b/g
> > > cards so we need to pick one.
> >
> > I think libertas_tf is still experimental at this time. Louis could
> > elaborate more.
>
> And that would be Luis (luisca) not Louis. Sorry Luis! :)

Heh, thanks. Hm, I thik Luis is on his trip around the world.

Luis

2008-11-12 15:55:29

by Dan Williams

[permalink] [raw]
Subject: Re: libertas_tf should replace libertas_usb on compat-wireless?

On Tue, 2008-11-11 at 16:32 -0800, Luis R. Rodriguez wrote:
> By default do we want users of compat-wireless to get libertas_usb or
> libertas_tf? Both drivers are for Marvell Libertas 8388 USB 802.11b/g
> cards so we need to pick one.

I think libertas_tf is still experimental at this time. Louis could
elaborate more.

Dan



2008-11-12 21:07:46

by Andrey Yurovsky

[permalink] [raw]
Subject: Re: libertas_tf should replace libertas_usb on compat-wireless?

libertas_tf is a softmac driver developed mainly so that XO's can run
hostapd and the like. libertas is the general (fullmac) driver and,
in my opinion, should be the one users get unless they specifically
wanted libertas_tf because they're experimenting with AP mode or other
mac80211 features. So I guess I'd vote for libertas over libertas_tf
at this time, for what it's worth.

-Andrey

On Wed, Nov 12, 2008 at 11:55 AM, Luis R. Rodriguez
<[email protected]> wrote:
> On Wed, Nov 12, 2008 at 09:57:29AM -0800, Dan Williams wrote:
>> On Wed, 2008-11-12 at 10:53 -0500, Dan Williams wrote:
>> > On Tue, 2008-11-11 at 16:32 -0800, Luis R. Rodriguez wrote:
>> > > By default do we want users of compat-wireless to get libertas_usb or
>> > > libertas_tf? Both drivers are for Marvell Libertas 8388 USB 802.11b/g
>> > > cards so we need to pick one.
>> >
>> > I think libertas_tf is still experimental at this time. Louis could
>> > elaborate more.
>>
>> And that would be Luis (luisca) not Louis. Sorry Luis! :)
>
> Heh, thanks. Hm, I thik Luis is on his trip around the world.
>
> Luis
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

2008-11-12 22:42:34

by Luis R. Rodriguez

[permalink] [raw]
Subject: Re: libertas_tf should replace libertas_usb on compat-wireless?

T24gV2VkLCBOb3YgMTIsIDIwMDggYXQgMjoyOSBQTSwgU3RlZmFuaWsgR8OhYm9yIDxuZXRyb2xs
bGVyLjNkQGdtYWlsLmNvbT4gd3JvdGU6Cj4gT24gV2VkLCBOb3YgMTIsIDIwMDggYXQgMTE6Mjcg
UE0sIEx1aXMgUi4gUm9kcmlndWV6Cj4gPGxyb2RyaWd1ZXpAYXRoZXJvcy5jb20+IHdyb3RlOgo+
PiBPbiBXZWQsIE5vdiAxMiwgMjAwOCBhdCAwMToxNjozNlBNIC0wODAwLCBTdGVmYW5payBHw6Fi
b3Igd3JvdGU6Cj4+PiBPbiBXZWQsIE5vdiAxMiwgMjAwOCBhdCAxMDowNyBQTSwgQW5kcmV5IFl1
cm92c2t5IDxhbmRyZXlAY296eWJpdC5jb20+IHdyb3RlOgo+Pj4gPiBsaWJlcnRhc190ZiBpcyBh
IHNvZnRtYWMgZHJpdmVyIGRldmVsb3BlZCBtYWlubHkgc28gdGhhdCBYTydzIGNhbiBydW4KPj4+
ID4gaG9zdGFwZCBhbmQgdGhlIGxpa2UuICBsaWJlcnRhcyBpcyB0aGUgZ2VuZXJhbCAoZnVsbG1h
YykgZHJpdmVyIGFuZCwKPj4+ID4gaW4gbXkgb3Bpbmlvbiwgc2hvdWxkIGJlIHRoZSBvbmUgdXNl
cnMgZ2V0IHVubGVzcyB0aGV5IHNwZWNpZmljYWxseQo+Pj4gPiB3YW50ZWQgbGliZXJ0YXNfdGYg
YmVjYXVzZSB0aGV5J3JlIGV4cGVyaW1lbnRpbmcgd2l0aCBBUCBtb2RlIG9yIG90aGVyCj4+PiA+
IG1hYzgwMjExIGZlYXR1cmVzLiAgU28gSSBndWVzcyBJJ2Qgdm90ZSBmb3IgbGliZXJ0YXMgb3Zl
ciBsaWJlcnRhc190Zgo+Pj4gPiBhdCB0aGlzIHRpbWUsIGZvciB3aGF0IGl0J3Mgd29ydGguCj4+
PiA+Cj4+PiA+ICAtQW5kcmV5Cj4+Pgo+Pj4gSSB0aGluayBsaWJlcnRhc191c2Igc2hvdWxkIGJl
IGEgZGVmYXVsdCAoYXMgaXQncyBIVyBhY2NlbGVyYXRlZCksIGJ1dAo+Pj4gbGliZXJ0YXNfdGYg
c2hvdWxkIGJlIGluY2x1ZGVkIGFzIGFuIG9wdGlvbiAoZGlzYWJsZWQgYnkgZGVmYXVsdCBpbgo+
Pj4gY29uZmlnLm1rLCBvciBhdXRvLWFkZGVkIHRvIC9ldGMvbW9kcHJvYmUuZC9ibGFja2xpc3Qg
dXBvbiBtYWtlCj4+PiBpbnN0YWxsKS4KPj4KPj4gT0sgc28gSSd2ZSBkb25lIHRoaXMgb24gY29u
ZmlnLm1rOgo+Pgo+PiBpZm5lcSAoJChDT05GSUdfVVNCKSwpCj4+IGlmbmVxICgkKENPTkZJR19M
SUJFUlRBU19USElORklSTV9VU0IpLG0pCj4+IENPTkZJR19MSUJFUlRBU19VU0I9bQo+PiBORUVE
X0xJQkVSVEFTPXkKPj4gZW5kaWYKPj4gZW5kaWYKPj4KPj4gVGhpcyBtZWFucyB5b3UnbGwgZ2V0
IENPTkZJR19MSUJFUlRBU19VU0IgdW5sZXNzIHlvdXIga2VybmVsCj4+IGFscmVhZHkgd2FzIGJ1
aWx0IHdpdGggQ09ORklHX0xJQkVSVEFTX1RISU5GSVJNX1VTQiBmb3IgYWxsIHRob3NlCj4+IGJ1
aWxkaW5nIHdpdGggaXQuIElmIHlvdXIga2VybmVsIHdhcyBidWlsdCB3aXRoIGJvdGggdGhlbiBp
dHMgeW91cgo+PiBwcm9ibGVtLgo+Pgo+PiAgTHVpcwo+Pgo+Cj4gSWYgdGhlIGtlcm5lbCBoYXMg
Ym90aCwgY29tcGF0LXdpcmVsZXNzIHNob3VsZCBhbHNvIGJ1aWxkIGJvdGguCgpUaGUga2VybmVs
IGhhcyBib3RoLCBjb21wYXQtd2lyZWxlc3MgaGFzIGJvdGggYnV0IHdlIHJlc3BlY3QgeW91cgpr
ZXJuZWwgLmNvbmZpZyB1bmxlc3Mgd2Uga25vdyBiZXR0ZXIgKHdlIHBpY2tlZCBiNDMgb3ZlciBi
Y200M3h4CmJlZm9yZSkuIEluIHRoaXMgY2FzZSB3ZSBkb24ndCB3YW50IHRvIHByZWZlciBvbmUg
b3ZlciB0aGUgb3RoZXIgc28gd2UKc2ltcGx5IHN0aWNrIHRvIHRoZSBkZWNpc2lvbiBvZiB3aG9l
dmVyIGJ1aWx0IHlvdXIga2VybmVsLgoKICBMdWlzCg==

2008-11-12 23:23:07

by Gábor Stefanik

[permalink] [raw]
Subject: Re: libertas_tf should replace libertas_usb on compat-wireless?

On Wed, Nov 12, 2008 at 11:32 PM, Luis R. Rodriguez
<[email protected]> wrote:
> On Wed, Nov 12, 2008 at 2:29 PM, Stefanik G=E1bor <netrolller.3d@gmai=
l.com> wrote:
>> On Wed, Nov 12, 2008 at 11:27 PM, Luis R. Rodriguez
>> <[email protected]> wrote:
>>> On Wed, Nov 12, 2008 at 01:16:36PM -0800, Stefanik G=E1bor wrote:
>>>> On Wed, Nov 12, 2008 at 10:07 PM, Andrey Yurovsky <andrey@cozybit.=
com> wrote:
>>>> > libertas_tf is a softmac driver developed mainly so that XO's ca=
n run
>>>> > hostapd and the like. libertas is the general (fullmac) driver =
and,
>>>> > in my opinion, should be the one users get unless they specifica=
lly
>>>> > wanted libertas_tf because they're experimenting with AP mode or=
other
>>>> > mac80211 features. So I guess I'd vote for libertas over libert=
as_tf
>>>> > at this time, for what it's worth.
>>>> >
>>>> > -Andrey
>>>>
>>>> I think libertas_usb should be a default (as it's HW accelerated),=
but
>>>> libertas_tf should be included as an option (disabled by default i=
n
>>>> config.mk, or auto-added to /etc/modprobe.d/blacklist upon make
>>>> install).
>>>
>>> OK so I've done this on config.mk:
>>>
>>> ifneq ($(CONFIG_USB),)
>>> ifneq ($(CONFIG_LIBERTAS_THINFIRM_USB),m)
>>> CONFIG_LIBERTAS_USB=3Dm
>>> NEED_LIBERTAS=3Dy
>>> endif
>>> endif
>>>
>>> This means you'll get CONFIG_LIBERTAS_USB unless your kernel
>>> already was built with CONFIG_LIBERTAS_THINFIRM_USB for all those
>>> building with it. If your kernel was built with both then its your
>>> problem.
>>>
>>> Luis
>>>
>>
>> If the kernel has both, compat-wireless should also build both.
>
> The kernel has both, compat-wireless has both but we respect your
> kernel .config unless we know better (we picked b43 over bcm43xx
> before). In this case we don't want to prefer one over the other so w=
e
> simply stick to the decision of whoever built your kernel.
>
> Luis
>

I mean if both are enabled, and both were built.

--=20
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)

2008-11-12 23:39:58

by Luis R. Rodriguez

[permalink] [raw]
Subject: Re: libertas_tf should replace libertas_usb on compat-wireless?

On Wed, Nov 12, 2008 at 03:23:05PM -0800, Stefanik G=E1bor wrote:
> On Wed, Nov 12, 2008 at 11:32 PM, Luis R. Rodriguez
> <[email protected]> wrote:
> > On Wed, Nov 12, 2008 at 2:29 PM, Stefanik G=E1bor <netrolller.3d@gm=
ail.com> wrote:
> >> On Wed, Nov 12, 2008 at 11:27 PM, Luis R. Rodriguez
> >> <[email protected]> wrote:
> >>> On Wed, Nov 12, 2008 at 01:16:36PM -0800, Stefanik G=E1bor wrote:
> >>>> On Wed, Nov 12, 2008 at 10:07 PM, Andrey Yurovsky <andrey@cozybi=
t.com> wrote:
> >>>> > libertas_tf is a softmac driver developed mainly so that XO's =
can run
> >>>> > hostapd and the like. libertas is the general (fullmac) drive=
r and,
> >>>> > in my opinion, should be the one users get unless they specifi=
cally
> >>>> > wanted libertas_tf because they're experimenting with AP mode =
or other
> >>>> > mac80211 features. So I guess I'd vote for libertas over libe=
rtas_tf
> >>>> > at this time, for what it's worth.
> >>>> >
> >>>> > -Andrey
> >>>>
> >>>> I think libertas_usb should be a default (as it's HW accelerated=
), but
> >>>> libertas_tf should be included as an option (disabled by default=
in
> >>>> config.mk, or auto-added to /etc/modprobe.d/blacklist upon make
> >>>> install).
> >>>
> >>> OK so I've done this on config.mk:
> >>>
> >>> ifneq ($(CONFIG_USB),)
> >>> ifneq ($(CONFIG_LIBERTAS_THINFIRM_USB),m)
> >>> CONFIG_LIBERTAS_USB=3Dm
> >>> NEED_LIBERTAS=3Dy
> >>> endif
> >>> endif
> >>>
> >>> This means you'll get CONFIG_LIBERTAS_USB unless your kernel
> >>> already was built with CONFIG_LIBERTAS_THINFIRM_USB for all those
> >>> building with it. If your kernel was built with both then its you=
r
> >>> problem.
> >>>
> >>> Luis
> >>>
> >>
> >> If the kernel has both, compat-wireless should also build both.
> >
> > The kernel has both, compat-wireless has both but we respect your
> > kernel .config unless we know better (we picked b43 over bcm43xx
> > before). In this case we don't want to prefer one over the other so=
we
> > simply stick to the decision of whoever built your kernel.
> >
> > Luis
> >
>=20
> I mean if both are enabled, and both were built.

OK yeah agreed, but if the user has nothing then we should pick one
for them too, in this case it'll be LIBERTAS_USB.

Luis

2008-11-12 17:59:34

by Dan Williams

[permalink] [raw]
Subject: Re: libertas_tf should replace libertas_usb on compat-wireless?

On Wed, 2008-11-12 at 10:53 -0500, Dan Williams wrote:
> On Tue, 2008-11-11 at 16:32 -0800, Luis R. Rodriguez wrote:
> > By default do we want users of compat-wireless to get libertas_usb or
> > libertas_tf? Both drivers are for Marvell Libertas 8388 USB 802.11b/g
> > cards so we need to pick one.
>
> I think libertas_tf is still experimental at this time. Louis could
> elaborate more.

And that would be Luis (luisca) not Louis. Sorry Luis! :)

Dan