2015-10-18 15:45:50

by Greg KH

[permalink] [raw]
Subject: Re: patch for rtl8712 driver, add support for sitecom WLA2100 (006c)

On Sun, Oct 18, 2015 at 04:34:51PM +0200, Frans van de Wiel wrote:
> dear sirs, please find attached a patch for the rtl8712 driver (staging)
> The patch add support for sitecom WLA2100, seems this device id is missing.
> Many dongles use it.
>
> Kind regards
> Frans



Can you reformat this in the way that the file
Documenatation/SubmittingPatches explains so that I can accept the
patch? As it is, I can't :(

thanks,

greg k-h


2015-10-18 17:58:37

by Frans van de Wiel

[permalink] [raw]
Subject: [PATCH 3.10-3.18] Driver, staging rtl8712, add support for sitecom WLA2100

The staging driver rtl8712 lacks support for dongles based on sitecom
WLA2100.
The current driver doesn't contain the usb id for this device, this patch
add it.

reported by: Frans van de Wiel <[email protected]>
Signed-off-by: Frans van de Wiel <[email protected]>
---
This patch is for stable kernels 3.14 to 3.18
Patch for 3.14.2 is included

--- linux-3.14.2/drivers/staging/rtl8712/usb_intf.c.orig 2014-04-27
02:19:26.000000000 +0200
+++ linux-3.14.2/drivers/staging/rtl8712/usb_intf.c 2014-03-25
22:31:33.000000000 +0100
@@ -144,6 +144,7 @@ static struct usb_device_id rtl871x_usb_
{USB_DEVICE(0x0DF6, 0x0058)},
{USB_DEVICE(0x0DF6, 0x0049)},
{USB_DEVICE(0x0DF6, 0x004C)},
+ {USB_DEVICE(0x0DF6, 0x006C)},
{USB_DEVICE(0x0DF6, 0x0064)},
/* Skyworth */
{USB_DEVICE(0x14b2, 0x3300)},
---

-----Oorspronkelijk bericht-----
From: Greg KH
Sent: Sunday, October 18, 2015 5:45 PM
To: Frans van de Wiel
Cc: [email protected] ; [email protected] ;
[email protected]
Subject: Re: patch for rtl8712 driver, add support for sitecom WLA2100
(006c)

On Sun, Oct 18, 2015 at 04:34:51PM +0200, Frans van de Wiel wrote:
> dear sirs, please find attached a patch for the rtl8712 driver (staging)
> The patch add support for sitecom WLA2100, seems this device id is
> missing.
> Many dongles use it.
>
> Kind regards
> Frans



Can you reformat this in the way that the file
Documenatation/SubmittingPatches explains so that I can accept the
patch? As it is, I can't :(

thanks,

greg k-h


2015-10-18 18:45:07

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH 3.10-3.18] Driver, staging rtl8712, add support for sitecom WLA2100

On Sun, Oct 18, 2015 at 07:58:30PM +0200, Frans van de Wiel wrote:
> The staging driver rtl8712 lacks support for dongles based on sitecom
> WLA2100.
> The current driver doesn't contain the usb id for this device, this patch
> add it.
>
> reported by: Frans van de Wiel <[email protected]>
> Signed-off-by: Frans van de Wiel <[email protected]>
> ---
> This patch is for stable kernels 3.14 to 3.18
> Patch for 3.14.2 is included

We can only apply new patches to the latest kernel version, not older
ones, as we can't go back in time :)

If you want a patch like this backported to older kernels, please read
Documentation/stable_kernel_rules.txt for how to do that.

>
> --- linux-3.14.2/drivers/staging/rtl8712/usb_intf.c.orig 2014-04-27
> 02:19:26.000000000 +0200
> +++ linux-3.14.2/drivers/staging/rtl8712/usb_intf.c 2014-03-25
> 22:31:33.000000000 +0100
> @@ -144,6 +144,7 @@ static struct usb_device_id rtl871x_usb_
> {USB_DEVICE(0x0DF6, 0x0058)},
> {USB_DEVICE(0x0DF6, 0x0049)},
> {USB_DEVICE(0x0DF6, 0x004C)},
> + {USB_DEVICE(0x0DF6, 0x006C)},
> {USB_DEVICE(0x0DF6, 0x0064)},
> /* Skyworth */
> {USB_DEVICE(0x14b2, 0x3300)},

Your patch was line-wrapped and the whitespace all messed up, and can't
be applied :(

Please make the patch against the linux-next tree and resend it so that
we have a chance to apply it.

thanks,

greg k-h

2015-10-18 19:16:40

by Frans van de Wiel

[permalink] [raw]
Subject: Re: [PATCH 3.10-3.18] Driver, staging rtl8712, add support for sitecom WLA2100

Hi Greg

thanks for your reply, forget the patch, apparently it is to complicated for
me

rgds, Frans



-----Oorspronkelijk bericht-----
From: Greg KH
Sent: Sunday, October 18, 2015 8:45 PM
To: Frans van de Wiel
Cc: [email protected] ; [email protected] ;
[email protected]
Subject: Re: [PATCH 3.10-3.18] Driver, staging rtl8712, add support for
sitecom WLA2100

On Sun, Oct 18, 2015 at 07:58:30PM +0200, Frans van de Wiel wrote:
> The staging driver rtl8712 lacks support for dongles based on sitecom
> WLA2100.
> The current driver doesn't contain the usb id for this device, this patch
> add it.
>
> reported by: Frans van de Wiel <[email protected]>
> Signed-off-by: Frans van de Wiel <[email protected]>
> ---
> This patch is for stable kernels 3.14 to 3.18
> Patch for 3.14.2 is included

We can only apply new patches to the latest kernel version, not older
ones, as we can't go back in time :)

If you want a patch like this backported to older kernels, please read
Documentation/stable_kernel_rules.txt for how to do that.

>
> --- linux-3.14.2/drivers/staging/rtl8712/usb_intf.c.orig 2014-04-27
> 02:19:26.000000000 +0200
> +++ linux-3.14.2/drivers/staging/rtl8712/usb_intf.c 2014-03-25
> 22:31:33.000000000 +0100
> @@ -144,6 +144,7 @@ static struct usb_device_id rtl871x_usb_
> {USB_DEVICE(0x0DF6, 0x0058)},
> {USB_DEVICE(0x0DF6, 0x0049)},
> {USB_DEVICE(0x0DF6, 0x004C)},
> + {USB_DEVICE(0x0DF6, 0x006C)},
> {USB_DEVICE(0x0DF6, 0x0064)},
> /* Skyworth */
> {USB_DEVICE(0x14b2, 0x3300)},

Your patch was line-wrapped and the whitespace all messed up, and can't
be applied :(

Please make the patch against the linux-next tree and resend it so that
we have a chance to apply it.

thanks,

greg k-h