2019-03-16 15:45:45

by Lorenzo Bianconi

Subject: [PATCH] mt7603: core: do not use magic numbers in mt7603_reg_map

Use register definitions instead of magic numbers in mt7603_reg_map

Signed-off-by: Lorenzo Bianconi <[email protected]>
---
drivers/net/wireless/mediatek/mt76/mt7603/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7603/core.c b/drivers/net/wireless/mediatek/mt76/mt7603/core.c
index e32a16f2ebe8..4668c573f74a 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7603/core.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7603/core.c
@@ -53,8 +53,8 @@ irqreturn_t mt7603_irq_handler(int irq, void *dev_instance)

u32 mt7603_reg_map(struct mt7603_dev *dev, u32 addr)
{
- u32 base = addr & GENMASK(31, 19);
- u32 offset = addr & GENMASK(18, 0);
+ u32 base = addr & MT_MCU_PCIE_REMAP_2_BASE;
+ u32 offset = addr & MT_MCU_PCIE_REMAP_2_OFFSET;

dev->bus_ops->wr(&dev->mt76, MT_MCU_PCIE_REMAP_2, base);

--
2.20.1

2019-03-16 19:27:00

by Felix Fietkau

Subject: Re: [PATCH] mt7603: core: do not use magic numbers in mt7603_reg_map

On 2019-03-16 16:45, Lorenzo Bianconi wrote:
> Use register definitions instead of magic numbers in mt7603_reg_map
>
> Signed-off-by: Lorenzo Bianconi <[email protected]>
Applied, thanks.

- Felix