2017-11-14 17:01:55

by Colin King

Subject: [PATCH] rtlwifi: rtl818x: remove redundant check for cck_power > 15

From: Colin Ian King <[email protected]>

cck_poweri cannot be greated than 15 as is derived from the bottom 4 bits
from riv->channels[channel - 1].hw_value & 0xf. Hence the check for it
being greater than 15 is redundant and can be removed.

Detected by CoverityScan, CID#744303 ("Logically dead code")

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/net/wireless/realtek/rtl818x/rtl8187/rtl8225.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtl818x/rtl8187/rtl8225.c b/drivers/net/wireless/realtek/rtl818x/rtl8187/rtl8225.c
index e6668ffb77e6..ff0971f1e2c8 100644
--- a/drivers/net/wireless/realtek/rtl818x/rtl8187/rtl8225.c
+++ b/drivers/net/wireless/realtek/rtl818x/rtl8187/rtl8225.c
@@ -688,10 +688,7 @@ static void rtl8225z2_b_rf_set_tx_power(struct ieee80211_hw *dev, int channel)
cck_power = priv->channels[channel - 1].hw_value & 0xF;
ofdm_power = priv->channels[channel - 1].hw_value >> 4;

- if (cck_power > 15)
- cck_power = (priv->hw_rev == RTL8187BvB) ? 15 : 22;
- else
- cck_power += (priv->hw_rev == RTL8187BvB) ? 0 : 7;
+ cck_power += (priv->hw_rev == RTL8187BvB) ? 0 : 7;
cck_power += priv->txpwr_base & 0xF;
cck_power = min(cck_power, (u8)35);

--
2.14.1

2017-12-04 22:58:02

by Hin-Tak Leung

Subject: Re: [PATCH] rtlwifi: rtl818x: remove redundant check for cck_power > 15

--------------------------------------------
On Tue, 14/11/17, Colin King <[email protected]> wrote:

=20
> From: Colin Ian King <[email protected]>
=20
> cck_poweri cannot be greated than 15 as
> is derived from the bottom 4 bits
> from riv->channels[channel -
> 1].hw_value & 0xf.=C2=A0 Hence the check for it
> being greater than 15 is redundant and
> can be removed.
=20
> Detected by CoverityScan, CID#744303
> ("Logically dead code")
=20
> Signed-off-by: Colin Ian King <[email protected]>
=20
Acked-by: Hin-Tak Leung <[email protected]>

2017-12-07 13:16:34

by Kalle Valo

Subject: Re: rtlwifi: rtl818x: remove redundant check for cck_power > 15

Colin Ian King <[email protected]> wrote:

> From: Colin Ian King <[email protected]>
>
> cck_poweri cannot be greated than 15 as is derived from the bottom 4 bits
> from riv->channels[channel - 1].hw_value & 0xf. Hence the check for it
> being greater than 15 is redundant and can be removed.
>
> Detected by CoverityScan, CID#744303 ("Logically dead code")
>
> Signed-off-by: Colin Ian King <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

45d9d1a12efa rtlwifi: rtl818x: remove redundant check for cck_power > 15

--
https://patchwork.kernel.org/patch/10057925/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches