2013-02-26 02:29:36

by Wei Yongjun

[permalink] [raw]
Subject: [PATCH -next] wil6210: convert to use simple_open()

From: Wei Yongjun <[email protected]>

This removes an open coded simple_open() function and
replaces file operations references to the function
with simple_open() instead.

Signed-off-by: Wei Yongjun <[email protected]>
---
drivers/net/wireless/ath/wil6210/debugfs.c | 14 +++-----------
1 file changed, 3 insertions(+), 11 deletions(-)

diff --git a/drivers/net/wireless/ath/wil6210/debugfs.c b/drivers/net/wireless/ath/wil6210/debugfs.c
index 65fc968..1e709bf 100644
--- a/drivers/net/wireless/ath/wil6210/debugfs.c
+++ b/drivers/net/wireless/ath/wil6210/debugfs.c
@@ -312,14 +312,6 @@ static const struct file_operations fops_memread = {
.llseek = seq_lseek,
};

-static int wil_default_open(struct inode *inode, struct file *file)
-{
- if (inode->i_private)
- file->private_data = inode->i_private;
-
- return 0;
-}
-
static ssize_t wil_read_file_ioblob(struct file *file, char __user *user_buf,
size_t count, loff_t *ppos)
{
@@ -361,7 +353,7 @@ static ssize_t wil_read_file_ioblob(struct file *file, char __user *user_buf,

static const struct file_operations fops_ioblob = {
.read = wil_read_file_ioblob,
- .open = wil_default_open,
+ .open = simple_open,
.llseek = default_llseek,
};

@@ -396,7 +388,7 @@ static ssize_t wil_write_file_reset(struct file *file, const char __user *buf,

static const struct file_operations fops_reset = {
.write = wil_write_file_reset,
- .open = wil_default_open,
+ .open = simple_open,
};
/*---------Tx descriptor------------*/

@@ -526,7 +518,7 @@ static ssize_t wil_write_file_ssid(struct file *file, const char __user *buf,
static const struct file_operations fops_ssid = {
.read = wil_read_file_ssid,
.write = wil_write_file_ssid,
- .open = wil_default_open,
+ .open = simple_open,
};

/*----------------*/




2013-02-26 08:22:42

by Vladimir Kondratiev

[permalink] [raw]
Subject: Re: [PATCH -next] wil6210: convert to use simple_open()

On Tuesday, February 26, 2013 10:29:34 AM Wei Yongjun wrote:
> From: Wei Yongjun <[email protected]>
>
> This removes an open coded simple_open() function and
> replaces file operations references to the function
> with simple_open() instead.
>
> Signed-off-by: Wei Yongjun <[email protected]>

Acked-by: Vladimir Kondratiev <[email protected]>

Thanks for this.

Vladimir.