2021-01-22 02:43:12

by Thara Gopinath

[permalink] [raw]
Subject: [PATCH v2 0/3] thermal: Replace thermal_notify_framework with thermal_zone_device_update

thermal_notify_framework just updates for a single trip point where as
thermal_zone_device_update does other bookkeeping like updating the
temperature of the thermal zone, running through the list of trip points
and setting the next trip point etc. Since the later is a more thorough
version of former, replace thermal_notify_framework with
thermal_zone_device_update.

v1->v2:
- Removed net: wireless: intel: from subject header of Patch 1
in the series as per Kalle Valo and added his Acked-by.
- Introduced Patch 3 removing thermal_notify_framework from
thermal documentation.

Thara Gopinath (3):
net: wireless: intel: iwlwifi: mvm: tt: Replace
thermal_notify_framework
drivers: thermal: Remove thermal_notify_framework
Documentation: driver-api: thermal: Remove thermal_notify_framework
from documentation

Documentation/driver-api/thermal/sysfs-api.rst | 12 +-----------
drivers/net/wireless/intel/iwlwifi/mvm/tt.c | 4 ++--
drivers/thermal/thermal_core.c | 18 ------------------
include/linux/thermal.h | 4 ----
4 files changed, 3 insertions(+), 35 deletions(-)

--
2.25.1


2021-01-22 02:46:12

by Thara Gopinath

[permalink] [raw]
Subject: [PATCH v2 3/3] Documentation: driver-api: thermal: Remove thermal_notify_framework from documentation

Since thermal_notify_framework is no longer supported/implemented
remove the entry from sysfs-api.rst.
---
Documentation/driver-api/thermal/sysfs-api.rst | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/Documentation/driver-api/thermal/sysfs-api.rst b/Documentation/driver-api/thermal/sysfs-api.rst
index e7520cb439ac..d5b6ca812873 100644
--- a/Documentation/driver-api/thermal/sysfs-api.rst
+++ b/Documentation/driver-api/thermal/sysfs-api.rst
@@ -743,17 +743,7 @@ This function returns the thermal_instance corresponding to a given
{thermal_zone, cooling_device, trip_point} combination. Returns NULL
if such an instance does not exist.

-4.3. thermal_notify_framework
------------------------------
-
-This function handles the trip events from sensor drivers. It starts
-throttling the cooling devices according to the policy configured.
-For CRITICAL and HOT trip points, this notifies the respective drivers,
-and does actual throttling for other trip points i.e ACTIVE and PASSIVE.
-The throttling policy is based on the configured platform data; if no
-platform data is provided, this uses the step_wise throttling policy.
-
-4.4. thermal_cdev_update
+4.3. thermal_cdev_update
------------------------

This function serves as an arbitrator to set the state of a cooling
--
2.25.1

2021-02-02 14:43:52

by Thara Gopinath

[permalink] [raw]
Subject: Re: [PATCH v2 0/3] thermal: Replace thermal_notify_framework with thermal_zone_device_update



On 1/21/21 9:34 PM, Thara Gopinath wrote:
> thermal_notify_framework just updates for a single trip point where as
> thermal_zone_device_update does other bookkeeping like updating the
> temperature of the thermal zone, running through the list of trip points
> and setting the next trip point etc. Since the later is a more thorough
> version of former, replace thermal_notify_framework with
> thermal_zone_device_update.

Hi!

Any more comments for this series? Can this be merged, please ?


Warm Regards
Thara
>
> v1->v2:
> - Removed net: wireless: intel: from subject header of Patch 1
> in the series as per Kalle Valo and added his Acked-by.
> - Introduced Patch 3 removing thermal_notify_framework from
> thermal documentation.
>
> Thara Gopinath (3):
> net: wireless: intel: iwlwifi: mvm: tt: Replace
> thermal_notify_framework
> drivers: thermal: Remove thermal_notify_framework
> Documentation: driver-api: thermal: Remove thermal_notify_framework
> from documentation
>
> Documentation/driver-api/thermal/sysfs-api.rst | 12 +-----------
> drivers/net/wireless/intel/iwlwifi/mvm/tt.c | 4 ++--
> drivers/thermal/thermal_core.c | 18 ------------------
> include/linux/thermal.h | 4 ----
> 4 files changed, 3 insertions(+), 35 deletions(-)
>