2023-05-22 10:55:34

by Niklas Schnelle

[permalink] [raw]
Subject: [PATCH v5 43/44] wireless: add HAS_IOPORT dependencies

In a future patch HAS_IOPORT=n will result in inb()/outb() and friends
not being declared. We thus need to add HAS_IOPORT as dependency for
those drivers using them.

Co-developed-by: Arnd Bergmann <[email protected]>
Signed-off-by: Arnd Bergmann <[email protected]>
Acked-by: Kalle Valo <[email protected]>
Signed-off-by: Niklas Schnelle <[email protected]>
---
drivers/net/wireless/atmel/Kconfig | 2 +-
drivers/net/wireless/intersil/hostap/Kconfig | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/atmel/Kconfig b/drivers/net/wireless/atmel/Kconfig
index ca45a1021cf4..bafdd57b049a 100644
--- a/drivers/net/wireless/atmel/Kconfig
+++ b/drivers/net/wireless/atmel/Kconfig
@@ -14,7 +14,7 @@ if WLAN_VENDOR_ATMEL

config ATMEL
tristate "Atmel at76c50x chipset 802.11b support"
- depends on CFG80211 && (PCI || PCMCIA)
+ depends on CFG80211 && (PCI || PCMCIA) && HAS_IOPORT
select WIRELESS_EXT
select WEXT_PRIV
select FW_LOADER
diff --git a/drivers/net/wireless/intersil/hostap/Kconfig b/drivers/net/wireless/intersil/hostap/Kconfig
index c865d3156cea..2edff8efbcbb 100644
--- a/drivers/net/wireless/intersil/hostap/Kconfig
+++ b/drivers/net/wireless/intersil/hostap/Kconfig
@@ -56,7 +56,7 @@ config HOSTAP_FIRMWARE_NVRAM

config HOSTAP_PLX
tristate "Host AP driver for Prism2/2.5/3 in PLX9052 PCI adaptors"
- depends on PCI && HOSTAP
+ depends on PCI && HOSTAP && HAS_IOPORT
help
Host AP driver's version for Prism2/2.5/3 PC Cards in PLX9052 based
PCI adaptors.
--
2.39.2



2023-05-24 07:42:08

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH v5 43/44] wireless: add HAS_IOPORT dependencies

Niklas Schnelle <[email protected]> wrote:

> In a future patch HAS_IOPORT=n will result in inb()/outb() and friends
> not being declared. We thus need to add HAS_IOPORT as dependency for
> those drivers using them.
>
> Co-developed-by: Arnd Bergmann <[email protected]>
> Signed-off-by: Arnd Bergmann <[email protected]>
> Acked-by: Kalle Valo <[email protected]>
> Signed-off-by: Niklas Schnelle <[email protected]>

Now that the dependencies are in v6.4-rc1 my plan is to take this to
wireless-next, is that ok for everyone?

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


2023-05-25 12:05:47

by Niklas Schnelle

[permalink] [raw]
Subject: Re: [PATCH v5 43/44] wireless: add HAS_IOPORT dependencies

On Wed, 2023-05-24 at 07:38 +0000, Kalle Valo wrote:
> Niklas Schnelle <[email protected]> wrote:
>
> > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends
> > not being declared. We thus need to add HAS_IOPORT as dependency for
> > those drivers using them.
> >
> > Co-developed-by: Arnd Bergmann <[email protected]>
> > Signed-off-by: Arnd Bergmann <[email protected]>
> > Acked-by: Kalle Valo <[email protected]>
> > Signed-off-by: Niklas Schnelle <[email protected]>
>
> Now that the dependencies are in v6.4-rc1 my plan is to take this to
> wireless-next, is that ok for everyone?
>

Yes okay by me. Thank you.