2010-02-17 17:05:04

by okias

[permalink] [raw]
Subject: [PATCH] rtl818x: small cleanup

-2 lines...

--
Jabber/XMPP: [email protected]
SIP VoIP: sip:[email protected]


Attachments:
0001-wireless-rtl818x-small-cleanup.patch (1.00 kB)

2010-02-17 17:23:08

by Hin-Tak Leung

[permalink] [raw]
Subject: Re: [PATCH] rtl818x: small cleanup

--- On Wed, 17/2/10, okias <[email protected]> wrote:

> -2 lines...

Acked,

The content is fine, but you know the kernel patch submission guide line explicitly states that patches should be in-line (use git-send-mail is easiest).





2010-02-17 17:15:55

by Larry Finger

[permalink] [raw]
Subject: Re: [PATCH] rtl818x: small cleanup

On 02/17/2010 11:05 AM, okias wrote:
> -2 lines...

Your patch is fine, but there are problems in the presentation. For review
purposes, it should be in-line, not as an attachment. The second problem is that
the patch is for rtl8187, not for wireless/rtl818x. There are 2 drivers, soon to
be more, in that particular directory.

Larry