2010-10-19 08:45:55

by Bala Shanmugam

Subject: [PATCH] Do not compile staging directory for bt target. Signed-off-by: Bala Shanmugam <[email protected]>

---
Makefile | 9 ++++-----
1 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/Makefile b/Makefile
index bca92ca..ec84197 100644
--- a/Makefile
+++ b/Makefile
@@ -31,17 +31,16 @@ obj-$(CONFIG_COMPAT_NET_USB_MODULES) += drivers/net/usb/

obj-$(CONFIG_COMPAT_NETWORK_MODULES) += drivers/net/
obj-$(CONFIG_COMPAT_VAR_MODULES) += drivers/ssb/ drivers/misc/eeprom/
-endif
-
-obj-$(CONFIG_COMPAT_BLUETOOTH) += net/bluetooth/
-obj-$(CONFIG_COMPAT_BLUETOOTH_MODULES) += drivers/bluetooth/
-

ifeq ($(CONFIG_STAGING_EXCLUDE_BUILD),)
obj-$(CONFIG_COMPAT_STAGING) += drivers/staging/ath6kl/
obj-$(CONFIG_COMPAT_STAGING) += drivers/staging/brcm80211/
endif

+endif
+
+obj-$(CONFIG_COMPAT_BLUETOOTH) += net/bluetooth/
+obj-$(CONFIG_COMPAT_BLUETOOTH_MODULES) += drivers/bluetooth/

else

--
1.6.3.3

2010-10-19 09:08:04

by Bala Shanmugam

Subject: Re: [PATCH] Do not compile staging directory for bt target. Signed-off-by: Bala Shanmugam <[email protected]>

On 10/19/2010 2:23 PM, Luis R. Rodriguez wrote:
> Applied, you may want a ./scripts/driver-select entry as well.
>
> Luis
Not needed for now as we have seperate targets to compile, install and
uninstall bluetooth modules.

Bala.

2010-10-19 08:54:18

by Luis R. Rodriguez

Subject: Re: [PATCH] Do not compile staging directory for bt target. Signed-off-by: Bala Shanmugam <[email protected]>

Applied, you may want a ./scripts/driver-select entry as well.

Luis

2010-10-19 13:35:03

by Walter Goldens

Subject: Re: [PATCH] Do not compile staging directory for bt target. Signed-off-by: Bala Shanmugam <[email protected]>

> Applied, you may want a

>
> ? Luis
I was just about to submit exactly the same patch :)

BTW, I was thinking, perhaps we could merge bt and ethernet drivers in one line, by two separate groups via driver-select. For example:
Replace current:
"Supported Ethernet drivers: < atl1 atl2 atl1e atl1c >"
with
"Supported Ethernet & Bluetooth drivers: < bt | eth (atlxx) >

or something like that. This will notify users they can actually install bt drivers /if they don't read documentation/.

Its a little weird that, atlxx are provided via driver-select and bt from 'make bt'. I believe they should be "on the same page"

I would also suggest we drop the load.sh and wlload.sh scripts. I can't think of a reason why a sane person would opt for such iffy, redundant and probably malignant way to load their respective driver.

There was something else, but I can't remember now ;)

Walter.

2010-10-19 16:59:27

by Luis R. Rodriguez

Subject: Re: [PATCH] Do not compile staging directory for bt target. Signed-off-by: Bala Shanmugam <[email protected]>

On Tue, Oct 19, 2010 at 6:35 AM, Walter Goldens
<[email protected]> wrote:
>
>> Applied, you may want a
>
>>
>>   Luis
> I was just about to submit exactly the same patch :)
>
> BTW,  I was thinking, perhaps we could merge bt and ethernet drivers in one line, by two separate groups via driver-select. For example:
> Replace current:
> "Supported Ethernet drivers: < atl1 atl2 atl1e atl1c >"
> with
> "Supported Ethernet & Bluetooth drivers: < bt | eth (atlxx) >
>
> or something like that. This will notify users they can actually install bt drivers /if they don't read documentation/.
>
> Its a little weird that, atlxx are provided via driver-select and bt from 'make bt'. I believe they should be "on the same page"

Agreed.

> I would also suggest we drop the load.sh and wlload.sh scripts. I can't think of a reason why a sane person would opt for such iffy, redundant and probably malignant way to load their respective driver.
>
> There was something else, but I can't remember now ;)

Agreed.

Luis