2023-09-14 04:08:45

by Wu Yunchuan

Subject: [PATCH wireless-next 6/9] wifi: ath10k: Remove unnecessary (void*) conversions

No need cast (void*) to (struct htt_rx_ring_setup_ring32 *),
(struct htt_rx_ring_setup_ring64 *), (struct ath_softc *)
or (struct ath_hw *).

Signed-off-by: Wu Yunchuan <[email protected]>
---
drivers/net/wireless/ath/ath10k/htt_tx.c | 6 ++----
drivers/net/wireless/ath/ath9k/pci.c | 6 +++---
2 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/htt_tx.c b/drivers/net/wireless/ath/ath10k/htt_tx.c
index bd603feb7953..31f08db8a42f 100644
--- a/drivers/net/wireless/ath/ath10k/htt_tx.c
+++ b/drivers/net/wireless/ath/ath10k/htt_tx.c
@@ -798,16 +798,14 @@ static int ath10k_htt_send_frag_desc_bank_cfg_64(struct ath10k_htt *htt)

static void ath10k_htt_fill_rx_desc_offset_32(struct ath10k_hw_params *hw, void *rx_ring)
{
- struct htt_rx_ring_setup_ring32 *ring =
- (struct htt_rx_ring_setup_ring32 *)rx_ring;
+ struct htt_rx_ring_setup_ring32 *ring = rx_ring;

ath10k_htt_rx_desc_get_offsets(hw, &ring->offsets);
}

static void ath10k_htt_fill_rx_desc_offset_64(struct ath10k_hw_params *hw, void *rx_ring)
{
- struct htt_rx_ring_setup_ring64 *ring =
- (struct htt_rx_ring_setup_ring64 *)rx_ring;
+ struct htt_rx_ring_setup_ring64 *ring = rx_ring;

ath10k_htt_rx_desc_get_offsets(hw, &ring->offsets);
}
diff --git a/drivers/net/wireless/ath/ath9k/pci.c b/drivers/net/wireless/ath/ath9k/pci.c
index 0633589b85c2..e655cd8bbf94 100644
--- a/drivers/net/wireless/ath/ath9k/pci.c
+++ b/drivers/net/wireless/ath/ath9k/pci.c
@@ -781,7 +781,7 @@ static const struct pci_device_id ath_pci_id_table[] = {
/* return bus cachesize in 4B word units */
static void ath_pci_read_cachesize(struct ath_common *common, int *csz)
{
- struct ath_softc *sc = (struct ath_softc *) common->priv;
+ struct ath_softc *sc = common->priv;
u8 u8tmp;

pci_read_config_byte(to_pci_dev(sc->dev), PCI_CACHE_LINE_SIZE, &u8tmp);
@@ -799,7 +799,7 @@ static void ath_pci_read_cachesize(struct ath_common *common, int *csz)

static bool ath_pci_eeprom_read(struct ath_common *common, u32 off, u16 *data)
{
- struct ath_hw *ah = (struct ath_hw *) common->ah;
+ struct ath_hw *ah = common->ah;

common->ops->read(ah, AR5416_EEPROM_OFFSET + (off << AR5416_EEPROM_S));

@@ -820,7 +820,7 @@ static bool ath_pci_eeprom_read(struct ath_common *common, u32 off, u16 *data)
/* Need to be called after we discover btcoex capabilities */
static void ath_pci_aspm_init(struct ath_common *common)
{
- struct ath_softc *sc = (struct ath_softc *) common->priv;
+ struct ath_softc *sc = common->priv;
struct ath_hw *ah = sc->sc_ah;
struct pci_dev *pdev = to_pci_dev(sc->dev);
struct pci_dev *parent;
--
2.30.2

2023-09-14 19:18:25

by Jeff Johnson

Subject: Re: [PATCH wireless-next 6/9] wifi: ath10k: Remove unnecessary (void*) conversions

On 9/13/2023 9:05 PM, Wu Yunchuan wrote:
> No need cast (void*) to (struct htt_rx_ring_setup_ring32 *),
> (struct htt_rx_ring_setup_ring64 *), (struct ath_softc *)
> or (struct ath_hw *).
>
> Signed-off-by: Wu Yunchuan <[email protected]>
> ---
> drivers/net/wireless/ath/ath10k/htt_tx.c | 6 ++----
> drivers/net/wireless/ath/ath9k/pci.c | 6 +++---

ath9k change should be in a separate patch since it has a different
maintainer than ath10k