LinuxLists.cc - mesh endian bugs

2009-11-19 14:28:14

Subject: mesh endian bugs

CHECK /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c
/home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:471:41: warning: incorrect type in argument 4 (different base types)
/home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:471:41: expected restricted __le16 [usertype] target_rcode
/home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:471:41: got int
/home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:617:36: warning: incorrect type in argument 4 (different base types)
/home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:617:36: expected restricted __le16 [usertype] target_rcode
/home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:617:36: got int

Attachments:

signature.asc (801.00 B)
This is a digitally signed message part

2009-11-19 15:50:09

by Rui Paulo

[permalink] [raw]

Subject: Re: mesh endian bugs

Hi,

On 19 Nov 2009, at 13:51, Johannes Berg wrote:

> CHECK /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c
> /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:471:41: warning: incorrect type in argument 4 (different base types)
> /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:471:41: expected restricted __le16 [usertype] target_rcode
> /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:471:41: got int
> /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:617:36: warning: incorrect type in argument 4 (different base types)
> /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:617:36: expected restricted __le16 [usertype] target_rcode
> /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:617:36: got int

Thanks Johannes. How does one perform this check?

--
Rui Paulo

2009-11-19 22:29:30

by Johannes Berg

[permalink] [raw]

Subject: Re: mesh endian bugs

On Thu, 2009-11-19 at 15:50 +0000, Rui Paulo wrote:
> Hi,
>
> On 19 Nov 2009, at 13:51, Johannes Berg wrote:
>
> > CHECK /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c
> > /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:471:41: warning: incorrect type in argument 4 (different base types)
> > /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:471:41: expected restricted __le16 [usertype] target_rcode
> > /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:471:41: got int
> > /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:617:36: warning: incorrect type in argument 4 (different base types)
> > /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:617:36: expected restricted __le16 [usertype] target_rcode
> > /home/johannes/sys/wireless-testing/net/mac80211/mesh_pathtbl.c:617:36: got int
>
> Thanks Johannes. How does one perform this check?

make M=net/mac80211 C=1

However, due to a stupid kmemcheck thing it's broken, runs into an error
in skbuff.h and you need to fix that first by removing the :16 on that
line.

johannes

Attachments:

signature.asc (801.00 B)
This is a digitally signed message part

2009-11-19 22:30:03

by Johannes Berg

[permalink] [raw]

Subject: Re: mesh endian bugs

On Thu, 2009-11-19 at 23:29 +0100, Johannes Berg wrote:

> make M=net/mac80211 C=1

or C=2 to check all files (C=1 checks files that are recompiled, C=2
checks all files)

johannes

Attachments:

signature.asc (801.00 B)
This is a digitally signed message part

2009-11-19 17:20:33

by Dan Williams

[permalink] [raw]