2018-09-27 04:36:57

by Maharaja Kennadyrajan

[permalink] [raw]
Subject: Re: [PATCH] ath10k: Add debugfs support to get power save state change of STA

On 2018-09-26 7:42 pm, Kalle Valo wrote:
> Maharaja Kennadyrajan <[email protected]> wrote:
>
>> This patch helps to get the power save state change of each peer
>> connected to the AP. With WMI_10_4_PEER_STA_PS_STATECHG_EVENTID
>> event, ps state of each peer is reported to user space via
>> debugfs.
>>
>> Use the below command to get the ps state of each sta:
>> cat /sys/kernel/debug/ieee80211/phyX/netdev::wlanX/stations/
>> XX:XX:XX:XX:XX:XX/peer_ps_state
>>
>> If STA is in power save state, we get the peer_ps_state value as 1.
>> if STA is not in power save state, we get the peer_ps_state value as
>> 0.
>> If ps_state event is disabled, we get the peer_ps_state value as 2.
>>
>> We can enable/disable the ps_state events using the debugfs flag
>> "ps_state_enable"
>>
>> echo Y > /sys/kernel/debug/ieee80211/phyX/ath10k/ps_state_enable
>>
>> Y = 1 to enable and Y = 0 to disable
>>
>> Tested in QCA4019 with firmware ver 10.4-3.2.1.1-00011
>>
>> Signed-off-by: Maharaja Kennadyrajan <[email protected]>
>> Signed-off-by: Kalle Valo <[email protected]>
>
> This introduced a new warning:
>
> drivers/net/wireless/ath/ath10k/wmi.c:5061:1: warning: symbol
> 'ath10k_wmi_event_peer_sta_ps_state_chg' was not declared. Should it
> be static?

[Maha]: Yes, it should be static.

> I fixed this in the pending branch.
[Maha]: Thanks Kalle.

--
Regards,
Maha