2024-01-19 09:38:09

by Lin Ma

Subject: [PATCH net-next v1] nl80211/cfg80211: add nla_policy for S1G band

Our detector has identified another case of an incomplete policy.
Specifically, the commit df78a0c0b67d ("nl80211: S1G band and channel
definitions") introduced the NL80211_BAND_S1GHZ attribute to
nl80211_band, but it neglected to update the
nl80211_match_band_rssi_policy accordingly.

Similar commits that add new band types, such as the initial
commit 1e1b11b6a111 ("nl80211/cfg80211: Specify band specific min RSSI
thresholds with sched scan"), the commit e548a1c36b11 ("cfg80211: add 6GHz
in code handling array with NUM_NL80211_BANDS entries"), and the
commit 63fa04266629 ("nl80211: Add LC placeholder band definition to
nl80211_band"), all require updates to the policy.
Failure to do so could result in accessing an attribute of unexpected
length in the function nl80211_parse_sched_scan_per_band_rssi.

To resolve this issue, this commit adds the policy for the
NL80211_BAND_S1GHZ attribute.

Signed-off-by: Lin Ma <[email protected]>
---
net/wireless/nl80211.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
index 60877b532993..980300621a60 100644
--- a/net/wireless/nl80211.c
+++ b/net/wireless/nl80211.c
@@ -911,6 +911,7 @@ nl80211_match_band_rssi_policy[NUM_NL80211_BANDS] = {
[NL80211_BAND_5GHZ] = { .type = NLA_S32 },
[NL80211_BAND_6GHZ] = { .type = NLA_S32 },
[NL80211_BAND_60GHZ] = { .type = NLA_S32 },
+ [NL80211_BAND_S1GHZ] = { .type = NLA_S32 },
[NL80211_BAND_LC] = { .type = NLA_S32 },
};

--
2.34.1

2024-01-19 09:43:17

by Lin Ma

Subject: Re: [PATCH net-next v1] nl80211/cfg80211: add nla_policy for S1G band

Hello there,

> Our detector has identified another case of an incomplete policy.
> ...

I mark the net-next tag for this one and a previous sent one in this
morning ([PATCH net-next v1] neighbour: complement nl_ntbl_parm_policy).

Please let me know if such nla_policy complementing should go net instead.

Thanks!

Regards
Lin

2024-01-19 15:10:11

by Lin Ma

Subject: Re: [PATCH net-next v1] nl80211/cfg80211: add nla_policy for S1G band

Hello Kalle,

>
> "Lin Ma" <[email protected]> writes:
>
> > Hello there,
> >
> >> Our detector has identified another case of an incomplete policy.
> >> ...
> >
> > I mark the net-next tag for this one and a previous sent one in this
> > morning ([PATCH net-next v1] neighbour: complement nl_ntbl_parm_policy).
> >
> > Please let me know if such nla_policy complementing should go net instead.
>
> nl80211 patches go to wireless or wireless-next.
>
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

OK I will resend a version with correct one.

Thanks
Lin