This is v2 of [1], with a number of cleanups added first based on
Christoph's feedback, making the actual constness patch much smaller and
cleaner.
I don't know who actually maintains relay, it's not in MAINTAINERS -
Cc'd Andrew just in case.
I'd think it would be simplest to queue patches 5-9 via whichever tree
the relay patches get merged. They're all one-liners so neglible
conflict potential.
BR,
Jani.
[1] http://lore.kernel.org/r/[email protected]
Cc: [email protected]
Cc: Jens Axboe <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: Kalle Valo <[email protected]>
Cc: [email protected]
Cc: QCA ath9k Development <[email protected]>
Cc: [email protected]
Cc: Christoph Hellwig <[email protected]>
Cc: Andrew Morton <[email protected]>
Jani Nikula (9):
relay: remove unused buf_mapped and buf_unmapped callbacks
relay: require non-NULL callbacks in relay_open()
relay: make create_buf_file and remove_buf_file callbacks mandatory
relay: allow the use of const callback structs
drm/i915: make relay callbacks const
ath10k: make relay callbacks const
ath11k: make relay callbacks const
ath9k: make relay callbacks const
blktrace: make relay callbacks const
drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 2 +-
drivers/net/wireless/ath/ath10k/spectral.c | 2 +-
drivers/net/wireless/ath/ath11k/spectral.c | 2 +-
.../net/wireless/ath/ath9k/common-spectral.c | 2 +-
include/linux/relay.h | 29 ++---
kernel/relay.c | 107 +++---------------
kernel/trace/blktrace.c | 2 +-
7 files changed, 26 insertions(+), 120 deletions(-)
--
2.20.1
Now that relay_open() accepts const callbacks, make relay callbacks
const.
Cc: Kalle Valo <[email protected]>
Cc: QCA ath9k Development <[email protected]>
Cc: [email protected]
Acked-by: Kalle Valo <[email protected]>
Signed-off-by: Jani Nikula <[email protected]>
---
drivers/net/wireless/ath/ath9k/common-spectral.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ath/ath9k/common-spectral.c b/drivers/net/wireless/ath/ath9k/common-spectral.c
index 21191955a7c1..e055adfb5361 100644
--- a/drivers/net/wireless/ath/ath9k/common-spectral.c
+++ b/drivers/net/wireless/ath/ath9k/common-spectral.c
@@ -1053,7 +1053,7 @@ static int remove_buf_file_handler(struct dentry *dentry)
return 0;
}
-static struct rchan_callbacks rfs_spec_scan_cb = {
+static const struct rchan_callbacks rfs_spec_scan_cb = {
.create_buf_file = create_buf_file_handler,
.remove_buf_file = remove_buf_file_handler,
};
--
2.20.1
Jani Nikula <[email protected]> writes:
> This is v2 of [1], with a number of cleanups added first based on
> Christoph's feedback, making the actual constness patch much smaller and
> cleaner.
>
> I don't know who actually maintains relay, it's not in MAINTAINERS -
> Cc'd Andrew just in case.
>
> I'd think it would be simplest to queue patches 5-9 via whichever tree
> the relay patches get merged. They're all one-liners so neglible
> conflict potential.
>
> BR,
> Jani.
>
>
> [1] http://lore.kernel.org/r/[email protected]
>
>
> Cc: [email protected]
> Cc: Jens Axboe <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: Kalle Valo <[email protected]>
> Cc: [email protected]
> Cc: QCA ath9k Development <[email protected]>
> Cc: [email protected]
> Cc: Christoph Hellwig <[email protected]>
> Cc: Andrew Morton <[email protected]>
>
>
> Jani Nikula (9):
> relay: remove unused buf_mapped and buf_unmapped callbacks
> relay: require non-NULL callbacks in relay_open()
> relay: make create_buf_file and remove_buf_file callbacks mandatory
> relay: allow the use of const callback structs
> drm/i915: make relay callbacks const
> ath10k: make relay callbacks const
> ath11k: make relay callbacks const
> ath9k: make relay callbacks const
> blktrace: make relay callbacks const
For ath9k, ath10k & ath11k:
Acked-by: Kalle Valo <[email protected]>
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches