2022-12-14 16:03:44

by Paul Cercueil

[permalink] [raw]
Subject: [PATCH] dt-bindings: bcm4329-fmac: Add ingenic,iw8103-fmac compatible string

The MIPS CI20 board has a Ingenic IW8103 chip, which is supposedly just
a rebranded Broadcom BCM4330.

Signed-off-by: Paul Cercueil <[email protected]>
---
.../devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
index fec1cc9b9a08..d092c1e7f3ef 100644
--- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
@@ -40,6 +40,7 @@ properties:
- brcm,bcm4359-fmac
- cypress,cyw4373-fmac
- cypress,cyw43012-fmac
+ - ingenic,iw8103-fmac
- const: brcm,bcm4329-fmac
- enum:
- brcm,bcm4329-fmac
--
2.35.1


2022-12-14 17:00:20

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: bcm4329-fmac: Add ingenic,iw8103-fmac compatible string

On 14/12/2022 16:59, Paul Cercueil wrote:
> The MIPS CI20 board has a Ingenic IW8103 chip, which is supposedly just
> a rebranded Broadcom BCM4330.
>
> Signed-off-by: Paul Cercueil <[email protected]>


Acked-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2022-12-19 12:08:34

by Arend Van Spriel

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: bcm4329-fmac: Add ingenic,iw8103-fmac compatible string

On 12/14/2022 5:53 PM, Krzysztof Kozlowski wrote:
> On 14/12/2022 16:59, Paul Cercueil wrote:
>> The MIPS CI20 board has a Ingenic IW8103 chip, which is supposedly just
>> a rebranded Broadcom BCM4330.
>>
>> Signed-off-by: Paul Cercueil <[email protected]>
>
>
> Acked-by: Krzysztof Kozlowski <[email protected]>

My guess is that Ingenic is not really a chip manufacturer, but this is
actually a wifi module using BCM4330 as wifi chip. Personally, I would
not add a compatible string for that and the commit message does not
offer any arguments for having this.

Regards,
Arend


Attachments:
smime.p7s (4.12 kB)
S/MIME Cryptographic Signature