2017-07-17 19:03:28

by Ian Molton

[permalink] [raw]
Subject: BUG: brcmfmac: rework headroom check in .start_xmit() causes 43430a1 to fail.

Hi folks,

I've found that:

270a6c1f65fe brcmfmac: rework headroom check in .start_xmit()

Causes the 43430a1 to become non-responsive. The log starts emitting
these messages:

brcmfmac: brcmf_proto_bcdc_hdrpull: wlan0: non-BCDC packet received,
flags 0x0
brcmfmac: brcmf_proto_bcdc_hdrpull: wlan0: non-BCDC packet received,
flags 0x0
brcmfmac: brcmf_proto_bcdc_hdrpull: wlan0: non-BCDC packet received,
flags 0x0
brcmfmac: brcmf_proto_bcdc_hdrpull: wlan0: non-BCDC packet received,
flags 0x0
brcmfmac: brcmf_proto_bcdc_hdrpull: wlan0: non-BCDC packet received,
flags 0x0
brcmfmac: brcmf_proto_bcdc_hdrpull: wlan0: non-BCDC packet received,
flags 0x0
brcmfmac: brcmf_proto_bcdc_hdrpull: wlan0: non-BCDC packet received,
flags 0x0
brcmfmac: brcmf_proto_bcdc_hdrpull: wlan0: non-BCDC packet received,
flags 0x0
brcmfmac: brcmf_proto_bcdc_hdrpull: wlan0: non-BCDC packet received,
flags 0x0
brcmfmac: brcmf_proto_bcdc_hdrpull: wlan0: non-BCDC packet received,
flags 0x0
net_ratelimit: 3 callbacks suppressed
brcmfmac: brcmf_proto_bcdc_hdrpull: wlan0: non-BCDC packet received,
flags 0x0
brcmfmac: brcmf_proto_bcdc_hdrpull: wlan0: non-BCDC packet received,
flags 0x0

Without this commit, the card works fine.

Again, Firmware version = wl0: Aug 29 2016 20:48:16 version 7.45.41.26
(r640327) FWID 01-4527cfab

Does anyone actually test these commits before applying to mainline?

Thats two total breakages I've found that are verifiable at module load
time in the last couple of hours.

Even if this is a case of me having old firmware - this should not cause
this issue- at worst the driver should refuse to load. Better, it should
disable or work around known bugs.

-Ian


2017-07-17 19:56:46

by Ian Molton

[permalink] [raw]
Subject: Re: BUG: brcmfmac: rework headroom check in .start_xmit() causes 43430a1 to fail.

On 17/07/17 20:14, Arend van Spriel wrote:
>
> On 17-07-17 21:03, Ian Molton wrote:
>> Hi folks,
>>
>> I've found that:
>>
>> 270a6c1f65fe brcmfmac: rework headroom check in .start_xmit()
>>
>> Causes the 43430a1 to become non-responsive. The log starts emitting
>> these messages:
>
> A fix is already pending in patchwork:
>
> https://patchwork.kernel.org/patch/9836383/

Confirmed, this fix does fix the breakage.

-Ian

2017-07-17 19:58:18

by Arend Van Spriel

[permalink] [raw]
Subject: Re: BUG: brcmfmac: rework headroom check in .start_xmit() causes 43430a1 to fail.



On 17-07-17 21:56, Ian Molton wrote:
> On 17/07/17 20:14, Arend van Spriel wrote:
>>
>> On 17-07-17 21:03, Ian Molton wrote:
>>> Hi folks,
>>>
>>> I've found that:
>>>
>>> 270a6c1f65fe brcmfmac: rework headroom check in .start_xmit()
>>>
>>> Causes the 43430a1 to become non-responsive. The log starts emitting
>>> these messages:
>>
>> A fix is already pending in patchwork:
>>
>> https://patchwork.kernel.org/patch/9836383/
>
> Confirmed, this fix does fix the breakage.

one to go...

Regards,
Arend

2017-07-17 19:14:56

by Arend Van Spriel

[permalink] [raw]
Subject: Re: BUG: brcmfmac: rework headroom check in .start_xmit() causes 43430a1 to fail.



On 17-07-17 21:03, Ian Molton wrote:
> Hi folks,
>
> I've found that:
>
> 270a6c1f65fe brcmfmac: rework headroom check in .start_xmit()
>
> Causes the 43430a1 to become non-responsive. The log starts emitting
> these messages:

A fix is already pending in patchwork:

https://patchwork.kernel.org/patch/9836383/

Thanks,
Arend