Drop a wrongly claimed USB ID.
Bastian Germann (1):
wifi: ath9k: Remove Qwest/Actiontec 802AIN ID
drivers/net/wireless/ath/ath9k/hif_usb.c | 2 --
1 file changed, 2 deletions(-)
--
2.39.2
Bastian Germann <[email protected]> writes:
> Drop a wrongly claimed USB ID.
>
> Bastian Germann (1):
> wifi: ath9k: Remove Qwest/Actiontec 802AIN ID
>
> drivers/net/wireless/ath/ath9k/hif_usb.c | 2 --
> 1 file changed, 2 deletions(-)
I can't find the actual patch anywhere, I only see the cover letter:
https://lore.kernel.org/all/[email protected]/
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
The USB device 1668:1200 is Qwest/Actiontec 802AIN which is also
correctly claimed to be supported by carl9170.
Supposedly, the successor 802AIN2 which has an ath9k compatible chip
whose USB ID (unknown) could be inserted instead.
Drop the ID from the wrong driver.
Signed-off-by: Bastian Germann <[email protected]>
---
drivers/net/wireless/ath/ath9k/hif_usb.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/hif_usb.c b/drivers/net/wireless/ath/ath9k/hif_usb.c
index f521dfa2f194..1395536720b0 100644
--- a/drivers/net/wireless/ath/ath9k/hif_usb.c
+++ b/drivers/net/wireless/ath/ath9k/hif_usb.c
@@ -42,8 +42,6 @@ static const struct usb_device_id ath9k_hif_usb_ids[] = {
{ USB_DEVICE(0x0cf3, 0x7015),
.driver_info = AR9287_USB }, /* Atheros */
- { USB_DEVICE(0x1668, 0x1200),
- .driver_info = AR9287_USB }, /* Verizon */
{ USB_DEVICE(0x0cf3, 0x7010),
.driver_info = AR9280_USB }, /* Atheros */
--
2.39.2
Bastian Germann <[email protected]> writes:
> The USB device 1668:1200 is Qwest/Actiontec 802AIN which is also
> correctly claimed to be supported by carl9170.
>
> Supposedly, the successor 802AIN2 which has an ath9k compatible chip
> whose USB ID (unknown) could be inserted instead.
>
> Drop the ID from the wrong driver.
>
> Signed-off-by: Bastian Germann <[email protected]>
Thanks, I see this patch now.
I guess there's a bug report somewhere, do you have a link?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Am 06.03.23 um 14:07 schrieb Kalle Valo:
> Bastian Germann <[email protected]> writes:
>
>> The USB device 1668:1200 is Qwest/Actiontec 802AIN which is also
>> correctly claimed to be supported by carl9170.
>>
>> Supposedly, the successor 802AIN2 which has an ath9k compatible chip
>> whose USB ID (unknown) could be inserted instead.
>>
>> Drop the ID from the wrong driver.
>>
>> Signed-off-by: Bastian Germann <[email protected]>
>
> Thanks, I see this patch now.
>
> I guess there's a bug report somewhere, do you have a link?
No, I happened to find this by chance while packaging the ath9k and carl9170 firmware for Debian,
which have the ID represented in an XML format:
https://salsa.debian.org/debian/open-ath9k-htc-firmware/-/blob/master/debian/firmware-ath9k-htc.metainfo.xml
Bastian Germann <[email protected]> writes:
> Am 06.03.23 um 14:07 schrieb Kalle Valo:
>> Bastian Germann <[email protected]> writes:
>>
>>> The USB device 1668:1200 is Qwest/Actiontec 802AIN which is also
>>> correctly claimed to be supported by carl9170.
>>>
>>> Supposedly, the successor 802AIN2 which has an ath9k compatible chip
>>> whose USB ID (unknown) could be inserted instead.
>>>
>>> Drop the ID from the wrong driver.
>>>
>>> Signed-off-by: Bastian Germann <[email protected]>
>>
>> Thanks, I see this patch now.
>>
>> I guess there's a bug report somewhere, do you have a link?
>
> No, I happened to find this by chance while packaging the ath9k and
> carl9170 firmware for Debian,
> which have the ID represented in an XML format:
> https://salsa.debian.org/debian/open-ath9k-htc-firmware/-/blob/master/debian/firmware-ath9k-htc.metainfo.xml
Do you mind if we add this (without the link) to the commit log? It's
good to always document the background of the patch.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Am 06.03.23 um 14:49 schrieb Kalle Valo:
> Bastian Germann <[email protected]> writes:
>
>> Am 06.03.23 um 14:07 schrieb Kalle Valo:
>>> Bastian Germann <[email protected]> writes:
>>>
>>>> The USB device 1668:1200 is Qwest/Actiontec 802AIN which is also
>>>> correctly claimed to be supported by carl9170.
>>>>
>>>> Supposedly, the successor 802AIN2 which has an ath9k compatible chip
The "which" should be removed as well.
>>>> whose USB ID (unknown) could be inserted instead.
>>>>
>>>> Drop the ID from the wrong driver.
>>>>
>>>> Signed-off-by: Bastian Germann <[email protected]>
>>>
>>> Thanks, I see this patch now.
>>>
>>> I guess there's a bug report somewhere, do you have a link?
>>
>> No, I happened to find this by chance while packaging the ath9k and
>> carl9170 firmware for Debian,
>> which have the ID represented in an XML format:
>> https://salsa.debian.org/debian/open-ath9k-htc-firmware/-/blob/master/debian/firmware-ath9k-htc.metainfo.xml
>
> Do you mind if we add this (without the link) to the commit log? It's
> good to always document the background of the patch.
Please go ahead.
Bastian Germann <[email protected]> writes:
> The USB device 1668:1200 is Qwest/Actiontec 802AIN which is also
> correctly claimed to be supported by carl9170.
>
> Supposedly, the successor 802AIN2 which has an ath9k compatible chip
> whose USB ID (unknown) could be inserted instead.
>
> Drop the ID from the wrong driver.
>
> Signed-off-by: Bastian Germann <[email protected]>
Acked-by: Toke Høiland-Jørgensen <[email protected]>
Bastian Germann <[email protected]> wrote:
> The USB device 1668:1200 is Qwest/Actiontec 802AIN which is also
> correctly claimed to be supported by carl9170.
>
> Supposedly, the successor 802AIN2 has an ath9k compatible chip
> whose USB ID (unknown) could be inserted instead.
>
> Drop the ID from the wrong driver. I happened to find this by chance while
> packaging the ath9k and carl9170 firmware for Debian.
>
> Signed-off-by: Bastian Germann <[email protected]>
> Acked-by: Toke Høiland-Jørgensen <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>
Patch applied to ath-next branch of ath.git, thanks.
f94d7a3a5107 wifi: ath9k: Remove Qwest/Actiontec 802AIN ID
--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches