2013-09-24 12:06:44

by Marek Puzyniak

Subject: [PATCH] ath10k: make monitor vdev down before stoping it

Following sequence causes FW crash:
-monitor vdev up,
-monitor vdev stop,
-monitor vdev delete.
Making monitor vdev down before stoping it works ok:
-monitor vdev up,
-monitor vdev down,
-monitor vdev stop,
-monitor vdev delete.

Signed-off-by: Marek Puzyniak <[email protected]>
---
drivers/net/wireless/ath/ath10k/mac.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 51988d9..24b94c8 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -567,12 +567,9 @@ static int ath10k_monitor_stop(struct ath10k *ar)

lockdep_assert_held(&ar->conf_mutex);

- /* For some reasons, ath10k_wmi_vdev_down() here couse
- * often ath10k_wmi_vdev_stop() to fail. Next we could
- * not run monitor vdev and driver reload
- * required. Don't see such problems we skip
- * ath10k_wmi_vdev_down() here.
- */
+ ret = ath10k_wmi_vdev_down(ar, ar->monitor_vdev_id);
+ if (ret)
+ ath10k_warn("Monitor vdev down failed: %d\n", ret);

ret = ath10k_wmi_vdev_stop(ar, ar->monitor_vdev_id);
if (ret)
--
1.8.1.2

2013-09-26 14:30:57

by Kalle Valo

Subject: Re: [PATCH] ath10k: make monitor vdev down before stoping it

Marek Puzyniak <[email protected]> writes:

> Following sequence causes FW crash:
> -monitor vdev up,
> -monitor vdev stop,
> -monitor vdev delete.
> Making monitor vdev down before stoping it works ok:
> -monitor vdev up,
> -monitor vdev down,
> -monitor vdev stop,
> -monitor vdev delete.
>
> Signed-off-by: Marek Puzyniak <[email protected]>

Thanks, applied.

--
Kalle Valo