2017-09-01 00:04:56

by Eric Bentley

Subject: Re: [PATCH v2] Correctly fail to suspend when SDIO does not support power on suspend

UmV0dXJuIGVycm9yIHdoZW4gZmFpbGluZyB0byBzZXQgcG93ZXIgbWFuYWdlbWVudCBjYXBhYmls
aXRpZXMgZmxhZy4gIFRoaXMgd2lsbCBjYXVzZSB0aGUgc3VzcGVuZCB0byBmYWlsIGJ1dCB0aGUg
cmFkaW8NCndpbGwgY29udGludWUgdG8gb3BlcmF0ZS4gIEFsbG93aW5nIHRoaXMgdG8gZmFpbCB3
aXRob3V0IHJlcG9ydGluZyBlcnJvciB3aWxsIGNhdXNlIHRoZSByYWRpbyB0byBiZSBub24tZnVu
Y3Rpb25hbCBvbiANCnJlc3VtZSBhcyBpdCB3aWxsIGhhdmUgbG9zdCBwb3dlci4NCg0KU2lnbmVk
LW9mZi1ieTogRXJpYyBCZW50bGV5IGVyaWMuYmVudGxleUBsYWlyZHRlY2guY29tDQotLS0NCnYy
OiBjb3JyZWN0ZWQgZXJyYW50ICggd2l0aCB7DQotLS0NCiBkcml2ZXJzL25ldC93aXJlbGVzcy9i
cm9hZGNvbS9icmNtODAyMTEvYnJjbWZtYWMvYmNtc2RoLmMgfCA0ICsrKy0NCiAxIGZpbGUgY2hh
bmdlZCwgMyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pDQoNCmRpZmYgLS1naXQgYS9kcml2
ZXJzL25ldC93aXJlbGVzcy9icm9hZGNvbS9icmNtODAyMTEvYnJjbWZtYWMvYmNtc2RoLmMgYi9k
cml2ZXJzL25ldC93aXJlbGVzcy9icm9hZGNvbS9icmNtODAyMTEvYnJjbWZtYWMvYmNtc2RoLmMN
CmluZGV4IDcyMTM5YjUuLjJmN2QwM2YgMTAwNjQ0DQotLS0gYS9kcml2ZXJzL25ldC93aXJlbGVz
cy9icm9hZGNvbS9icmNtODAyMTEvYnJjbWZtYWMvYmNtc2RoLmMNCisrKyBiL2RyaXZlcnMvbmV0
L3dpcmVsZXNzL2Jyb2FkY29tL2JyY204MDIxMS9icmNtZm1hYy9iY21zZGguYw0KQEAgLTEyNjQs
OCArMTI2NCwxMCBAQCBzdGF0aWMgaW50IGJyY21mX29wc19zZGlvX3N1c3BlbmQoc3RydWN0IGRl
dmljZSAqZGV2KQ0KICAgICAgICAgICAgICAgICBlbHNlDQogICAgICAgICAgICAgICAgICAgICAg
ICAgc2Rpb19mbGFncyB8PSBNTUNfUE1fV0FLRV9TRElPX0lSUTsNCiAgICAgICAgIH0NCi0gICAg
ICAgaWYgKHNkaW9fc2V0X2hvc3RfcG1fZmxhZ3Moc2Rpb2Rldi0+ZnVuY1sxXSwgc2Rpb19mbGFn
cykpDQorICAgICAgIGlmIChzZGlvX3NldF9ob3N0X3BtX2ZsYWdzKHNkaW9kZXYtPmZ1bmNbMV0s
IHNkaW9fZmxhZ3MpKSB7DQogICAgICAgICAgICAgICAgIGJyY21mX2VycigiRmFpbGVkIHRvIHNl
dCBwbV9mbGFncyAleFxuIiwgc2Rpb19mbGFncyk7DQorICAgICAgICAgICAgICAgcmV0dXJuIC1F
SU5WQUw7DQorICAgICAgIH0NCiAgICAgICAgIHJldHVybiAwOw0KIH0NCiANCi0tIA0KMi42LjAu
R0lUDQoNCg0K

2017-09-01 05:30:33

by Kalle Valo

Subject: Re: [PATCH v2] Correctly fail to suspend when SDIO does not support power on suspend

Eric Bentley <[email protected]> writes:

> Return error when failing to set power management capabilities flag. This will cause the suspend to fail but the radio
> will continue to operate. Allowing this to fail without reporting error will cause the radio to be non-functional on
> resume as it will have lost power.
>
> Signed-off-by: Eric Bentley [email protected]

Word wrap the commit log to 72 chars (or so) per line. Also add a prefix
to the title:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_title_is_wrong

--
Kalle Valo