David Lin <[email protected]> writes:
>> From: Francesco Dolcini <[email protected]>
>> Sent: Friday, October 20, 2023 11:25 PM
>> To: David Lin <[email protected]>
>> Cc: [email protected]; [email protected];
>> [email protected]; [email protected]; [email protected]; Sharvari
>> Harisangam <[email protected]>; Pete Hsieh
>> <[email protected]>
>> Subject: [EXT] Re: [PATCH v6 0/6] wifi: mwifiex: added code to support host
>> mlme.
>>
>> Caution: This is an external email. Please take care when clicking links or
>> opening attachments. When in doubt, report the message using the 'Report
>> this email' button
>>
>>
>> On Fri, Oct 20, 2023 at 03:48:06AM +0000, David Lin wrote:
>> > Patch v6:
>> > Correct mailing sequence.
>>
>> You are still doing something wrong sending the patches over email, the
>> various emails are not threaded as expected, git-send-email should do
>> everything for you.
>>
>> No need to re-send now IMO, but please figure out what's wrong for the next
>> time.
>>
>> To give you an idea here [1] you see this email alone.
>>
>> This [2] and this [3] are examples of a properly sent patch series (just random
>> series from your NXP colleagues).
>>
>> You have also a winmail.dat file attached to every email in this series, not sure
>> what it is, but I would try to not send it.
>>
>
> Yes. I can send them as a single e-mail. However, I find other member
> would send multiple patches as separate e-mails with a cover letter. I
> think it would be easier for review.
We are not asking to send the patches as single email. We are asking to
run git send-email only _once_ per patchset to make sure threading is
correct (ie. References and In-Reply-to headers are set). For example,
you can do it like this:
$ git format-patch --base=auto --cover-letter -o outgoing/ main
outgoing/0000-cover-letter.patch
outgoing/0001-First-Commit.patch
outgoing/...
$ git send-email [...] outgoing/
More info:
https://wireless.wiki.kernel.org/en/developers/documentation/git-guide
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
> From: Kalle Valo <[email protected]>
> Sent: Monday, October 23, 2023 5:08 PM
> To: David Lin <[email protected]>
> Cc: Francesco Dolcini <[email protected]>; [email protected];
> [email protected]; [email protected]; Sharvari
> Harisangam <[email protected]>; Pete Hsieh
> <[email protected]>
> Subject: Re: [EXT] Re: [PATCH v6 0/6] wifi: mwifiex: added code to support host
> mlme.
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>
>
> David Lin <[email protected]> writes:
>
> >> From: Francesco Dolcini <[email protected]>
> >> Sent: Friday, October 20, 2023 11:25 PM
> >> To: David Lin <[email protected]>
> >> Cc: [email protected]; [email protected];
> >> [email protected]; [email protected]; [email protected];
> >> Sharvari Harisangam <[email protected]>; Pete Hsieh
> >> <[email protected]>
> >> Subject: [EXT] Re: [PATCH v6 0/6] wifi: mwifiex: added code to
> >> support host mlme.
> >>
> >> Caution: This is an external email. Please take care when clicking
> >> links or opening attachments. When in doubt, report the message using
> >> the 'Report this email' button
> >>
> >>
> >> On Fri, Oct 20, 2023 at 03:48:06AM +0000, David Lin wrote:
> >> > Patch v6:
> >> > Correct mailing sequence.
> >>
> >> You are still doing something wrong sending the patches over email,
> >> the various emails are not threaded as expected, git-send-email
> >> should do everything for you.
> >>
> >> No need to re-send now IMO, but please figure out what's wrong for
> >> the next time.
> >>
> >> To give you an idea here [1] you see this email alone.
> >>
> >> This [2] and this [3] are examples of a properly sent patch series
> >> (just random series from your NXP colleagues).
> >>
> >> You have also a winmail.dat file attached to every email in this
> >> series, not sure what it is, but I would try to not send it.
> >>
> >
> > Yes. I can send them as a single e-mail. However, I find other member
> > would send multiple patches as separate e-mails with a cover letter. I
> > think it would be easier for review.
>
> We are not asking to send the patches as single email. We are asking to run git
> send-email only _once_ per patchset to make sure threading is correct (ie.
> References and In-Reply-to headers are set). For example, you can do it like
> this:
>
> $ git format-patch --base=auto --cover-letter -o outgoing/ main
> outgoing/0000-cover-letter.patch outgoing/0001-First-Commit.patch
> outgoing/...
>
> $ git send-email [...] outgoing/
Thanks for your information. We will follow this way for Patch v7.
>
> More info:
>
> https://wireless/.
> wiki.kernel.org%2Fen%2Fdevelopers%2Fdocumentation%2Fgit-guide&data=05
> %7C01%7Cyu-hao.lin%40nxp.com%7C61329a44c6e344221c0a08dbd3a78bef%
> 7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638336488782298560
> %7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJ
> BTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=JTeuKeS8LQphE
> QYR%2BeBK1ENgR7L9ny0S9Nv15Ku1keE%3D&reserved=0
>
> https://www.ker/
> nel.org%2Fdoc%2Fhtml%2Flatest%2Fprocess%2Fsubmitting-patches.html&data
> =05%7C01%7Cyu-hao.lin%40nxp.com%7C61329a44c6e344221c0a08dbd3a78b
> ef%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638336488782298
> 560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIi
> LCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=i5Q5Hj9w6X
> zRo3phK9UcSaOzoHeJbxpmpB2TRIfyhak%3D&reserved=0
>
> --
> https://patchwor/
> k.kernel.org%2Fproject%2Flinux-wireless%2Flist%2F&data=05%7C01%7Cyu-hao
> .lin%40nxp.com%7C61329a44c6e344221c0a08dbd3a78bef%7C686ea1d3bc2b4
> c6fa92cd99c5c301635%7C0%7C0%7C638336488782298560%7CUnknown%7CT
> WFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJX
> VCI6Mn0%3D%7C3000%7C%7C%7C&sdata=TdWVJj9KpejI6kQfQnF9R7u3Ohz8
> U1o9xYiiDUcasag%3D&reserved=0
>
> https://wireless/.
> wiki.kernel.org%2Fen%2Fdevelopers%2Fdocumentation%2Fsubmittingpatches
> &data=05%7C01%7Cyu-hao.lin%40nxp.com%7C61329a44c6e344221c0a08dbd
> 3a78bef%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6383364887
> 82298560%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2
> luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=VjDp0
> T4L%2FjqG2lnHG0EJLpWEA6mAcBCXFhwTwMfakg0%3D&reserved=0