2008-11-09 15:01:07

by David Shwatrz

[permalink] [raw]
Subject: Where is allow-ap-vlan-modes.patch ?

Hello,

I have a question:
Why was the allow-ap-vlan-modes.patch removed from
http://johannes.sipsolutions.net/patches/kernel/all/LATEST/?

I see that it was there until recently (to be accurate,
30.10.08 was the last time it was there).

I do not see that it was applied; I have the latest git tree of
wireless-2.6 and wireless-next-2.6

Could it be that it was omitted as a result of some error ?


(This patch is mentioned for example, in
/Documentation/networking/mac80211_hwsim/README,
as you probably know)


Rgs,
DS


2008-11-10 19:00:44

by Luis R. Rodriguez

[permalink] [raw]
Subject: Re: Where is allow-ap-vlan-modes.patch ?

T24gTW9uLCBOb3YgMTAsIDIwMDggYXQgMTA6NTQgQU0sIFN0ZWZhbmlrIEfDoWJvcgo8bmV0cm9s
bGxlci4zZEBnbWFpbC5jb20+IHdyb3RlOgo+IE9uIE1vbiwgTm92IDEwLCAyMDA4IGF0IDQ6NDIg
UE0sIERhdmlkIFNod2F0cnogPGRzaHdhdHJ6QGdtYWlsLmNvbT4gd3JvdGU6Cj4+IEhlbGxvLAo+
PiBGaXJzdCwgSSBob3BlIHlvdSBmZWVsIGJldHRlciBzb29uLgo+Pgo+PiBTZWNvbmQ6Cj4+IExv
b2tpbmcgYXQgdGhlIHBhdGNoZXMgYXQgdGhlIG1haWxpbmcgbGlzdCwgSSBkbyBub3Qgc2VlCj4+
IHRoYXQgYW55d2hlcmUgaXQgc2F5cyBhZ2FpbnN0IHdoaWNoIGdpdCB0cmVlIHRoZXkgd2VyZSBt
YWRlLgo+PiBJdCBjb3VsZCBiZSA6IHdpcmVsZXNzLW5leHQtMi42LHdpcmVsZXNzLTIuNiwgYW5k
IHdpcmVsZXNzLXRlc3RpbmcuCj4+Cj4+IEkgZ3Vlc3MgdGhhdCB0aGVyZSBhcmUgbWFueSBjYXNl
cyBpbiB3aGljaCBhIHBhdGNoIGNhbiBiZSBhcHBsaWVkIHRvCj4+IHR3byBvZiB0aGVzZSB0cmVl
cyAob3IgbWF5YmUgYWxsIHRocmVlIG9mIHRoZW0pLAo+PiB3aGVyZWFzIHRoZXJlIGFyZSB0aW1l
cyBpbiB3aGljaCBpdCBjYW4gYmUgYXBwbGllZCB0byBvbmx5IG9uZSBnaXQgdHJlZS4KPj4KPj4g
SG93IGlzIGl0IGRldGVybWluZWQgdG8gd2hpY2ggdHJlZSB0aGUgcGF0Y2hlcyBzaG91bGQgYmUK
Pj4gYXBwbGllZCA/Cj4+Cj4+IFJncywKPj4gRFMKPj4KPj4gT24gTW9uLCBOb3YgMTAsIDIwMDgg
YXQgNDoyOCBQTSwgSm9obiBXLiBMaW52aWxsZQo+PiA8bGludmlsbGVAdHV4ZHJpdmVyLmNvbT4g
d3JvdGU6Cj4+PiBPbiBNb24sIE5vdiAxMCwgMjAwOCBhdCAxMTowMjoyMkFNICswMjAwLCBLYWxs
ZSBWYWxvIHdyb3RlOgo+Pj4+IERhdmlkIFNod2F0cnogPGRzaHdhdHJ6QGdtYWlsLmNvbT4gd3Jp
dGVzOgo+Pj4+Cj4+Pj4gPiBJbiB0aGlzIG9jY2FzaW9uIG1heSBJIGFzayAtIHdoYXQgaXMgdGhl
IHdpcmVsZXNzLXRlc3RpbmcgZ2l0IHRyZWU/Cj4+Pj4gPiBpcyBpdCBiYXNlZCBvbiB3aXJlbGVz
cy1uZXh0LTIuNiBvciBvbiB3aXJlbGVzcy0yLjYgdHJlZT8KPj4+Pgo+Pj4+IEl0J3MgYmFzZWQg
b24gTGludXMnIHJjIHJlbGVhc2VzIGFuZCBoYXMgYWxsIHRoZSB3aXJlbGVzcyBwYXRjaGVzCj4+
Pj4gd2hpY2ggaGF2ZSBiZWVuIHVuZGVyIGRldmVsb3BtZW50LiBJIHRoaW5rIEpvaG4gY2hlcnJ5
IHBpY2tzIHRoZQo+Pj4+IHBhdGNoZXMgZnJvbSB3aXJlbGVzcy10ZXN0aW5nIHRvIHdpcmVsZXNz
LTIuNiBvciB3aXJlbGVzcy1uZXh0LTIuNi4gU28KPj4+PiB3aXJlbGVzcy10ZXN0aW5nIGNvbnRh
aW5zIHRoZSBibGVlZGluZyBlZGdlIHdpcmVsZXNzIHBhdGNoZXMgYW5kIGlmCj4+Pj4gSm9obiB0
aGlua3MgdGhleSBhcmUgZ29vZCBlbm91Z2gsIGhlIHN1Ym1pdHMgdGhlbSBmb3J3YXJkLgo+Pj4+
Cj4+Pj4gUGxlYXNlIGNvcnJlY3QgbWUgaWYgSSBoYXZlIHVuZGVyc3Rvb2Qgc29tZXRoaW5nIHdy
b25nLgo+Pj4KPj4+IFRoYXQgaXMgYmFzaWNhbGx5IHJpZ2h0Lgo+Pj4KPj4+IEluIHRoZSBwYXN0
IHBhdGNoZXMgb2Z0ZW4gd2VudCB0byB3aXJlbGVzcy10ZXN0aW5nIGFuZCB0bwo+Pj4gd2lyZWxl
c3MtbmV4dC0yLjYvd2lyZWxlc3MtMi42IGF0IHRoZSBhYm91dCB0aGUgc2FtZSB0aW1lLiAgSG93
ZXZlcgo+Pj4gdXBzdHJlYW0gc3RhbmRhcmRzIGhhdmUgdGlnaHRlbmVkIGluIHdheXMgdGhhdCBt
YWtlIG1lIGZlZWwgaXQgaXMKPj4+IGFwcHJvcHJpYXRlIHRvIGdpdmUgcGF0Y2hlcyBtb3JlIHB1
YmxpYyB0ZXN0aW5nIGV2ZW4gYmVmb3JlIHNlbmRpbmcKPj4+IHRoZW0gZm9yIC1uZXh0Lgo+Pj4K
Pj4+IEluIHRoaXMgY2FzZSwgSSB3YXMgYWxzbyBzaWNrIGFsbCBsYXN0IHdlZWsgd2hpY2ggaGFz
IHNsb3dlZCB0aGluZwo+Pj4gYSBiaXQgbW9yZS4uLgo+Pj4KPj4+IFRoYW5rcywKPj4+Cj4+PiBK
b2huCj4+PiAtLQo+Pj4gSm9obiBXLiBMaW52aWxsZSAgICAgICAgICAgICAgICBMaW51eCBzaG91
bGQgYmUgYXQgdGhlIGNvcmUKPj4+IGxpbnZpbGxlQHR1eGRyaXZlci5jb20gICAgICAgICAgICAg
ICAgICBvZiB5b3VyIGxpdGVyYXRlIGxpZmVzdHlsZS4KPj4+Cj4+IC0tCj4+IFRvIHVuc3Vic2Ny
aWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmliZSBsaW51eC13aXJl
bGVzcyIgaW4KPj4gdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5l
bC5vcmcKPj4gTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9t
YWpvcmRvbW8taW5mby5odG1sCj4+Cj4KPiBUaGUgdGFyZ2V0IHRyZWUgdXNlZCB0byBiZSB3aXJl
bGVzcy0yLjYncyAiZXZlcnl0aGluZyIgYnJhbmNoLiBUaGVyZQo+IHdhcyBhIGxvdCBvZiBjb25m
dXNpb24gb3ZlciBwZW9wbGUgbWlzdGFrZW5seSBwdWxsaW5nICJtYXN0ZXIiIGluc3RlYWQKPiBv
ZiAiZXZlcnl0aGluZyIgKCJtYXN0ZXIiIGlzIHRoZSBkZWZhdWx0KSwgc28gdGhlICJldmVyeXRo
aW5nIiBicmFuY2gKPiB3YXMgcmVwbGFjZWQgYnkgYSBzZXBhcmF0ZSByZXBvLCB3aXJlbGVzcy10
ZXN0aW5nLgoKV2UgYWxzbyB0cnkgdG8ga2VlcCB0aGlzIHR5cGUgb2YgaW5mb3JtYXRpb24gdXAg
dG8gZGF0ZSBpbiBvdXIgd2lraToKCmh0dHA6Ly93aXJlbGVzcy5rZXJuZWwub3JnL2VuL2RldmVs
b3BlcnMvRG9jdW1lbnRhdGlvbgoKICBMdWlzCg==

2008-11-09 15:17:04

by Kalle Valo

[permalink] [raw]
Subject: Re: Where is allow-ap-vlan-modes.patch ?

Ivo van Doorn <[email protected]> writes:

>> I have a question:
>> Why was the allow-ap-vlan-modes.patch removed from
>> http://johannes.sipsolutions.net/patches/kernel/all/LATEST/?
>>
>> I see that it was there until recently (to be accurate,
>> 30.10.08 was the last time it was there).
>>
>> I do not see that it was applied; I have the latest git tree of
>> wireless-2.6 and wireless-next-2.6
>
> It is currently present in the wireless-testing git tree.

Yes, I can verify that. I have AP mode working in b43 using latest
hostapd from git and wireless-testing.

--
Kalle Valo

2008-11-10 14:31:08

by John W. Linville

[permalink] [raw]
Subject: Re: Where is allow-ap-vlan-modes.patch ?

On Mon, Nov 10, 2008 at 11:02:22AM +0200, Kalle Valo wrote:
> David Shwatrz <[email protected]> writes:
>
> > In this occasion may I ask - what is the wireless-testing git tree?
> > is it based on wireless-next-2.6 or on wireless-2.6 tree?
>
> It's based on Linus' rc releases and has all the wireless patches
> which have been under development. I think John cherry picks the
> patches from wireless-testing to wireless-2.6 or wireless-next-2.6. So
> wireless-testing contains the bleeding edge wireless patches and if
> John thinks they are good enough, he submits them forward.
>
> Please correct me if I have understood something wrong.

That is basically right.

In the past patches often went to wireless-testing and to
wireless-next-2.6/wireless-2.6 at the about the same time. However
upstream standards have tightened in ways that make me feel it is
appropriate to give patches more public testing even before sending
them for -next.

In this case, I was also sick all last week which has slowed thing
a bit more...

Thanks,

John
--
John W. Linville Linux should be at the core
[email protected] of your literate lifestyle.

2008-11-10 18:54:46

by Gábor Stefanik

[permalink] [raw]
Subject: Re: Where is allow-ap-vlan-modes.patch ?

On Mon, Nov 10, 2008 at 4:42 PM, David Shwatrz <[email protected]> wrote:
> Hello,
> First, I hope you feel better soon.
>
> Second:
> Looking at the patches at the mailing list, I do not see
> that anywhere it says against which git tree they were made.
> It could be : wireless-next-2.6,wireless-2.6, and wireless-testing.
>
> I guess that there are many cases in which a patch can be applied to
> two of these trees (or maybe all three of them),
> whereas there are times in which it can be applied to only one git tree.
>
> How is it determined to which tree the patches should be
> applied ?
>
> Rgs,
> DS
>
> On Mon, Nov 10, 2008 at 4:28 PM, John W. Linville
> <[email protected]> wrote:
>> On Mon, Nov 10, 2008 at 11:02:22AM +0200, Kalle Valo wrote:
>>> David Shwatrz <[email protected]> writes:
>>>
>>> > In this occasion may I ask - what is the wireless-testing git tree?
>>> > is it based on wireless-next-2.6 or on wireless-2.6 tree?
>>>
>>> It's based on Linus' rc releases and has all the wireless patches
>>> which have been under development. I think John cherry picks the
>>> patches from wireless-testing to wireless-2.6 or wireless-next-2.6. So
>>> wireless-testing contains the bleeding edge wireless patches and if
>>> John thinks they are good enough, he submits them forward.
>>>
>>> Please correct me if I have understood something wrong.
>>
>> That is basically right.
>>
>> In the past patches often went to wireless-testing and to
>> wireless-next-2.6/wireless-2.6 at the about the same time. However
>> upstream standards have tightened in ways that make me feel it is
>> appropriate to give patches more public testing even before sending
>> them for -next.
>>
>> In this case, I was also sick all last week which has slowed thing
>> a bit more...
>>
>> Thanks,
>>
>> John
>> --
>> John W. Linville Linux should be at the core
>> [email protected] of your literate lifestyle.
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

The target tree used to be wireless-2.6's "everything" branch. There
was a lot of confusion over people mistakenly pulling "master" instead
of "everything" ("master" is the default), so the "everything" branch
was replaced by a separate repo, wireless-testing.

--
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)

2008-11-10 16:16:10

by John W. Linville

[permalink] [raw]
Subject: Re: Where is allow-ap-vlan-modes.patch ?

On Mon, Nov 10, 2008 at 05:42:56PM +0200, David Shwatrz wrote:
> Hello,
> First, I hope you feel better soon.
>
> Second:
> Looking at the patches at the mailing list, I do not see
> that anywhere it says against which git tree they were made.
> It could be : wireless-next-2.6,wireless-2.6, and wireless-testing.
>
> I guess that there are many cases in which a patch can be applied to
> two of these trees (or maybe all three of them),
> whereas there are times in which it can be applied to only one git tree.
>
> How is it determined to which tree the patches should be
> applied ?

I ask for people to send patches against wireless-testing in general.

John
--
John W. Linville Linux should be at the core
[email protected] of your literate lifestyle.

2008-11-10 09:03:19

by Kalle Valo

[permalink] [raw]
Subject: Re: Where is allow-ap-vlan-modes.patch ?

David Shwatrz <[email protected]> writes:

> In this occasion may I ask - what is the wireless-testing git tree?
> is it based on wireless-next-2.6 or on wireless-2.6 tree?

It's based on Linus' rc releases and has all the wireless patches
which have been under development. I think John cherry picks the
patches from wireless-testing to wireless-2.6 or wireless-next-2.6. So
wireless-testing contains the bleeding edge wireless patches and if
John thinks they are good enough, he submits them forward.

Please correct me if I have understood something wrong.

--
Kalle Valo

2008-11-10 08:48:28

by David Shwatrz

[permalink] [raw]
Subject: Re: Where is allow-ap-vlan-modes.patch ?

Hello,
Thanks. I got the testing git tree; it is indeed there (though in a
bit different form; the method in net/mac80211/cfg.c is called
nl80211_type_check() and not nl80211_type_to_mac80211_type() as in the
patch from
allow-ap-vlan-modes.patch (2008-06-12). But it allows master mode for AP.

In this occasion may I ask - what is the wireless-testing git tree?
is it based on wireless-next-2.6 or on wireless-2.6 tree?

Regards,
DS



On Sun, Nov 9, 2008 at 5:04 PM, Ivo van Doorn <[email protected]> wrote:
> On Sunday 09 November 2008, David Shwatrz wrote:
>> Hello,
>>
>> I have a question:
>> Why was the allow-ap-vlan-modes.patch removed from
>> http://johannes.sipsolutions.net/patches/kernel/all/LATEST/?
>>
>> I see that it was there until recently (to be accurate,
>> 30.10.08 was the last time it was there).
>>
>> I do not see that it was applied; I have the latest git tree of
>> wireless-2.6 and wireless-next-2.6
>
> It is currently present in the wireless-testing git tree.
>
> Ivo
>

2008-11-10 15:42:59

by David Shwatrz

[permalink] [raw]
Subject: Re: Where is allow-ap-vlan-modes.patch ?

Hello,
First, I hope you feel better soon.

Second:
Looking at the patches at the mailing list, I do not see
that anywhere it says against which git tree they were made.
It could be : wireless-next-2.6,wireless-2.6, and wireless-testing.

I guess that there are many cases in which a patch can be applied to
two of these trees (or maybe all three of them),
whereas there are times in which it can be applied to only one git tree.

How is it determined to which tree the patches should be
applied ?

Rgs,
DS

On Mon, Nov 10, 2008 at 4:28 PM, John W. Linville
<[email protected]> wrote:
> On Mon, Nov 10, 2008 at 11:02:22AM +0200, Kalle Valo wrote:
>> David Shwatrz <[email protected]> writes:
>>
>> > In this occasion may I ask - what is the wireless-testing git tree?
>> > is it based on wireless-next-2.6 or on wireless-2.6 tree?
>>
>> It's based on Linus' rc releases and has all the wireless patches
>> which have been under development. I think John cherry picks the
>> patches from wireless-testing to wireless-2.6 or wireless-next-2.6. So
>> wireless-testing contains the bleeding edge wireless patches and if
>> John thinks they are good enough, he submits them forward.
>>
>> Please correct me if I have understood something wrong.
>
> That is basically right.
>
> In the past patches often went to wireless-testing and to
> wireless-next-2.6/wireless-2.6 at the about the same time. However
> upstream standards have tightened in ways that make me feel it is
> appropriate to give patches more public testing even before sending
> them for -next.
>
> In this case, I was also sick all last week which has slowed thing
> a bit more...
>
> Thanks,
>
> John
> --
> John W. Linville Linux should be at the core
> [email protected] of your literate lifestyle.
>

2008-11-09 15:04:48

by Ivo Van Doorn

[permalink] [raw]
Subject: Re: Where is allow-ap-vlan-modes.patch ?

On Sunday 09 November 2008, David Shwatrz wrote:
> Hello,
>
> I have a question:
> Why was the allow-ap-vlan-modes.patch removed from
> http://johannes.sipsolutions.net/patches/kernel/all/LATEST/?
>
> I see that it was there until recently (to be accurate,
> 30.10.08 was the last time it was there).
>
> I do not see that it was applied; I have the latest git tree of
> wireless-2.6 and wireless-next-2.6

It is currently present in the wireless-testing git tree.

Ivo