2016-03-11 06:14:43

by Kolli, Anilkumar

Subject: [PATCH v2] ath10k: fix debugfs pktlog_filter write

From: Anilkumar Kolli <[email protected]>

It is observed that, we are disabling the packet log if we write same
value to the pktlog_filter for the second time. Always enable pktlogs
on non zero filter.

Fixes: 90174455ae05 ("ath10k: add support to configure pktlog filter")
Cc: [email protected]
Signed-off-by: Anilkumar Kolli <[email protected]>
---
v2:
* added [email protected]

drivers/net/wireless/ath/ath10k/debug.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/debug.c b/drivers/net/wireless/ath/ath10k/debug.c
index 076d29b53ddf..0f834646e6a7 100644
--- a/drivers/net/wireless/ath/ath10k/debug.c
+++ b/drivers/net/wireless/ath/ath10k/debug.c
@@ -2019,7 +2019,12 @@ static ssize_t ath10k_write_pktlog_filter(struct file *file,
goto out;
}

- if (filter && (filter != ar->debug.pktlog_filter)) {
+ if (filter == ar->debug.pktlog_filter) {
+ ret = count;
+ goto out;
+ }
+
+ if (filter) {
ret = ath10k_wmi_pdev_pktlog_enable(ar, filter);
if (ret) {
ath10k_warn(ar, "failed to enable pktlog filter %x: %d\n",
--
1.7.9.5

2016-03-18 07:57:43

by Kalle Valo

Subject: Re: [PATCH v2] ath10k: fix debugfs pktlog_filter write

<[email protected]> writes:

> From: Anilkumar Kolli <[email protected]>
>
> It is observed that, we are disabling the packet log if we write same
> value to the pktlog_filter for the second time. Always enable pktlogs
> on non zero filter.
>
> Fixes: 90174455ae05 ("ath10k: add support to configure pktlog filter")
> Cc: [email protected]
> Signed-off-by: Anilkumar Kolli <[email protected]>

Applied, thanks.

--
Kalle Valo