2008-12-21 10:28:21

by Johannes Berg

[permalink] [raw]
Subject: new sparse warnings

These showed up in the nightly pull from yesterday:

> +drivers/net/wireless/iwlwifi/iwl3945-base.c:7436:5: warning: symbol 'iwl3945_init_drv' was not declared. Should it be static?
> +drivers/net/wireless/iwlwifi/iwl-3945.c:1325:5: warning: symbol 'iwl3945_apm_reset' was not declared. Should it be static?
> +net/mac80211/util.c:355:6: warning: symbol 'ieee80211_wake_queue_by_reason' was not declared. Should it be static?
> +net/mac80211/util.c:385:6: warning: symbol 'ieee80211_stop_queue_by_reason' was not declared. Should it be static?
>


Attachments:
signature.asc (836.00 B)
This is a digitally signed message part

2008-12-22 11:21:37

by Kalle Valo

[permalink] [raw]
Subject: Re: new sparse warnings

Johannes Berg <[email protected]> writes:

> These showed up in the nightly pull from yesterday:
>

[...]

>> +net/mac80211/util.c:355:6: warning: symbol 'ieee80211_wake_queue_by_reason' was not declared. Should it be static?
>> +net/mac80211/util.c:385:6: warning: symbol 'ieee80211_stop_queue_by_reason' was not declared. Should it be static?

Sorry about that, I'll send a fix later this week.

--
Kalle Valo