2015-01-20 10:27:21

by Michal Kazior

Subject: [PATCH] ath10k: disable irqs after fw crash

It makes little sense to keep handling irqs if fw
is dead.

This prevents multiple fw register dumps upon
crash on some devices (seen on QCA6174).

Signed-off-by: Michal Kazior <[email protected]>
---
drivers/net/wireless/ath/ath10k/pci.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
index 3b40a86..fba6618 100644
--- a/drivers/net/wireless/ath/ath10k/pci.c
+++ b/drivers/net/wireless/ath/ath10k/pci.c
@@ -2047,6 +2047,7 @@ static void ath10k_msi_err_tasklet(unsigned long data)
return;
}

+ ath10k_pci_irq_disable(ar);
ath10k_pci_fw_crashed_clear(ar);
ath10k_pci_fw_crashed_dump(ar);
}
@@ -2116,6 +2117,7 @@ static void ath10k_pci_tasklet(unsigned long data)
struct ath10k_pci *ar_pci = ath10k_pci_priv(ar);

if (ath10k_pci_has_fw_crashed(ar)) {
+ ath10k_pci_irq_disable(ar);
ath10k_pci_fw_crashed_clear(ar);
ath10k_pci_fw_crashed_dump(ar);
return;
--
1.8.5.3

2015-01-27 14:23:22

by Kalle Valo

Subject: Re: [PATCH] ath10k: disable irqs after fw crash

Michal Kazior <[email protected]> writes:

> It makes little sense to keep handling irqs if fw
> is dead.
>
> This prevents multiple fw register dumps upon
> crash on some devices (seen on QCA6174).
>
> Signed-off-by: Michal Kazior <[email protected]>

Thanks, applied to ath.git.

--
Kalle Valo