2012-05-07 09:22:09

by Zefir Kurtisi

Subject: [PATCH] [trivial] nl80211: fix typos in comments

Signed-off-by: Zefir Kurtisi <[email protected]>
---
include/linux/nl80211.h | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/linux/nl80211.h b/include/linux/nl80211.h
index 2540e86..f296a64 100644
--- a/include/linux/nl80211.h
+++ b/include/linux/nl80211.h
@@ -1994,9 +1994,9 @@ enum nl80211_reg_rule_flags {
* enum nl80211_dfs_regions - regulatory DFS regions
*
* @NL80211_DFS_UNSET: Country has no DFS master region specified
- * @NL80211_DFS_FCC_: Country follows DFS master rules from FCC
- * @NL80211_DFS_FCC_: Country follows DFS master rules from ETSI
- * @NL80211_DFS_JP_: Country follows DFS master rules from JP/MKK/Telec
+ * @NL80211_DFS_FCC: Country follows DFS master rules from FCC
+ * @NL80211_DFS_ETSI: Country follows DFS master rules from ETSI
+ * @NL80211_DFS_JP: Country follows DFS master rules from JP/MKK/Telec
*/
enum nl80211_dfs_regions {
NL80211_DFS_UNSET = 0,
--
1.7.4.1

2012-05-07 09:41:17

by Johannes Berg

Subject: Re: [PATCH] [trivial] nl80211: fix typos in comments

On Mon, 2012-05-07 at 12:35 +0300, Kalle Valo wrote:
> Zefir Kurtisi <[email protected]> writes:
>
> > - * @NL80211_DFS_FCC_: Country follows DFS master rules from FCC
> > - * @NL80211_DFS_FCC_: Country follows DFS master rules from ETSI
> > - * @NL80211_DFS_JP_: Country follows DFS master rules from JP/MKK/Telec
> > + * @NL80211_DFS_FCC: Country follows DFS master rules from FCC
> > + * @NL80211_DFS_ETSI: Country follows DFS master rules from ETSI
> > + * @NL80211_DFS_JP: Country follows DFS master rules from JP/MKK/Telec
>
> Are there any user space applications which use these enums? If there are,
> this change will break them which is bad (tm).

No, it actually just fixes kernel-doc .. the constant names are spelled
wrong in the comment.

johannes

2012-05-07 09:45:14

by Zefir Kurtisi

Subject: Re: [PATCH] [trivial] nl80211: fix typos in comments

On 05/07/2012 11:41 AM, Johannes Berg wrote:
> On Mon, 2012-05-07 at 12:35 +0300, Kalle Valo wrote:
>> Zefir Kurtisi <[email protected]> writes:
>>
>>> - * @NL80211_DFS_FCC_: Country follows DFS master rules from FCC
>>> - * @NL80211_DFS_FCC_: Country follows DFS master rules from ETSI
>>> - * @NL80211_DFS_JP_: Country follows DFS master rules from JP/MKK/Telec
>>> + * @NL80211_DFS_FCC: Country follows DFS master rules from FCC
>>> + * @NL80211_DFS_ETSI: Country follows DFS master rules from ETSI
>>> + * @NL80211_DFS_JP: Country follows DFS master rules from JP/MKK/Telec
>>
>> Are there any user space applications which use these enums? If there are,
>> this change will break them which is bad (tm).
>
> No, it actually just fixes kernel-doc .. the constant names are spelled
> wrong in the comment.
>
> johannes
>
Yep, 'trivial' since only C&P typos fixed. Or is there a better tag for
non functional modifications (comments, indentation, etc.)?

2012-05-07 09:46:52

by Kalle Valo

Subject: Re: [PATCH] [trivial] nl80211: fix typos in comments

Johannes Berg <[email protected]> writes:

> On Mon, 2012-05-07 at 12:35 +0300, Kalle Valo wrote:
>> Zefir Kurtisi <[email protected]> writes:
>>
>> > - * @NL80211_DFS_FCC_: Country follows DFS master rules from FCC
>> > - * @NL80211_DFS_FCC_: Country follows DFS master rules from ETSI
>> > - * @NL80211_DFS_JP_: Country follows DFS master rules from JP/MKK/Telec
>> > + * @NL80211_DFS_FCC: Country follows DFS master rules from FCC
>> > + * @NL80211_DFS_ETSI: Country follows DFS master rules from ETSI
>> > + * @NL80211_DFS_JP: Country follows DFS master rules from JP/MKK/Telec
>>
>> Are there any user space applications which use these enums? If there are,
>> this change will break them which is bad (tm).
>
> No, it actually just fixes kernel-doc .. the constant names are spelled
> wrong in the comment.

Hah, I was blind again. I blame Monday morning for this ;)

Sorry for the noise.

--
Kalle Valo

2012-05-07 09:35:46

by Kalle Valo

Subject: Re: [PATCH] [trivial] nl80211: fix typos in comments

Zefir Kurtisi <[email protected]> writes:

> - * @NL80211_DFS_FCC_: Country follows DFS master rules from FCC
> - * @NL80211_DFS_FCC_: Country follows DFS master rules from ETSI
> - * @NL80211_DFS_JP_: Country follows DFS master rules from JP/MKK/Telec
> + * @NL80211_DFS_FCC: Country follows DFS master rules from FCC
> + * @NL80211_DFS_ETSI: Country follows DFS master rules from ETSI
> + * @NL80211_DFS_JP: Country follows DFS master rules from JP/MKK/Telec

Are there any user space applications which use these enums? If there are,
this change will break them which is bad (tm).

--
Kalle Valo