2020-02-11 12:48:14

by Toke Høiland-Jørgensen

[permalink] [raw]
Subject: Re: [PATCH 1/2] mac80211: allow setting queue_len for drivers not using wake_tx_queue

John Crispin <[email protected]> writes:

> Currently a mac80211 driver can only set the txq_limit when using
> wake_tx_queue. Not all drivers use wake_tx_queue. This patch adds a new
> element to wiphy allowing a driver to set a custom tx_queue_len and the
> code that will apply it in case it is set. The current default is
> 1000 which is too low for ath11k when doing HE rates.

Fine, but we should really fix ath11k to do something smarter than a
fixed queue len... 4096 packets is 6 seconds of queueing at 8Mbps :/

-Toke