2022-09-08 18:25:51

by Tamizh Chelvam Raja

Subject: [PATCH] wifi: cfg80211: Fix MCS divisor value

Bitrate for HE/EHT MCS6 is calculated wrongly due to the incorrect
MCS divisor value for mcs6. Fix it with the proper value.

previous mcs_divisor value = (11769/6144) = 1.915527

fixed mcs_divisor value = (11377/6144) = 1.851725

Fixes 9c97c88d2 ("cfg80211: Add support to calculate and report 4096-QAM HE rates")

Signed-off-by: Tamizh Chelvam Raja <[email protected]>
---
net/wireless/util.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/wireless/util.c b/net/wireless/util.c
index 0b28d00ba8f5..01493568a21d 100644
--- a/net/wireless/util.c
+++ b/net/wireless/util.c
@@ -1361,7 +1361,7 @@ static u32 cfg80211_calculate_bitrate_he(struct rate_info *rate)
25599, /* 4.166666... */
17067, /* 2.777777... */
12801, /* 2.083333... */
- 11769, /* 1.851851... */
+ 11377, /* 1.851725... */
10239, /* 1.666666... */
8532, /* 1.388888... */
7680, /* 1.250000... */
@@ -1444,7 +1444,7 @@ static u32 cfg80211_calculate_bitrate_eht(struct rate_info *rate)
25599, /* 4.166666... */
17067, /* 2.777777... */
12801, /* 2.083333... */
- 11769, /* 1.851851... */
+ 11377, /* 1.851725... */
10239, /* 1.666666... */
8532, /* 1.388888... */
7680, /* 1.250000... */
--
2.17.1

2022-09-09 09:06:44

by Kalle Valo

Subject: Re: [PATCH] wifi: cfg80211: Fix MCS divisor value

Tamizh Chelvam Raja <[email protected]> writes:

> Bitrate for HE/EHT MCS6 is calculated wrongly due to the incorrect
> MCS divisor value for mcs6. Fix it with the proper value.
>
> previous mcs_divisor value = (11769/6144) = 1.915527
>
> fixed mcs_divisor value = (11377/6144) = 1.851725
>
> Fixes 9c97c88d2 ("cfg80211: Add support to calculate and report 4096-QAM HE rates")

The format for Fixes tag should be:

Fixes: 9c97c88d2f4b ("cfg80211: Add support to calculate and report 4096-QAM HE rates")

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches