2018-03-08 08:40:48

by Kalle Valo

Subject: Variable-length arrays considered bad

Hi,

in an lkml discussion[1] it was mentioned that variable-length arrays
should not be used. Few warnings were found[2] from wireless:

drivers/net/wireless/ath/ath9k/dfs.c:104:2: warning: ISO C90 forbids variable length array 'max_bin' [-Wvla]
drivers/net/wireless/rsi/rsi_91x_sdio.c:570:2: warning: ISO C90 forbids variable length array 'temp_buf' [-Wvla]

Patches welcome.

[1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com

[2] http://paste.ubuntu.com/p/srQxwPQS9s/

--
Kalle Valo

2018-03-09 07:28:56

by Amitkumar Karwar

Subject: Re: Variable-length arrays considered bad

On Thu, Mar 8, 2018 at 2:10 PM, Kalle Valo <[email protected]> wrote:
> Hi,
>
> in an lkml discussion[1] it was mentioned that variable-length arrays
> should not be used. Few warnings were found[2] from wireless:
>
> drivers/net/wireless/ath/ath9k/dfs.c:104:2: warning: ISO C90 forbids variable length array 'max_bin' [-Wvla]
> drivers/net/wireless/rsi/rsi_91x_sdio.c:570:2: warning: ISO C90 forbids variable length array 'temp_buf' [-Wvla]
>
> Patches welcome.
>
> [1] https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com
>
> [2] http://paste.ubuntu.com/p/srQxwPQS9s/
>

I will submit a cleanup patch for RSI warning

Regards,
Amitkumar Karwar

2018-03-09 10:38:04

by Kalle Valo

Subject: Re: Variable-length arrays considered bad

Amitkumar Karwar <[email protected]> writes:

> On Thu, Mar 8, 2018 at 2:10 PM, Kalle Valo <[email protected]> wrote:
>> Hi,
>>
>> in an lkml discussion[1] it was mentioned that variable-length arrays
>> should not be used. Few warnings were found[2] from wireless:
>>
>> drivers/net/wireless/ath/ath9k/dfs.c:104:2: warning: ISO C90 forbids
>> variable length array 'max_bin' [-Wvla]
>> drivers/net/wireless/rsi/rsi_91x_sdio.c:570:2: warning: ISO C90
>> forbids variable length array 'temp_buf' [-Wvla]
>>
>> Patches welcome.
>>
>> [1]
>> https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qPXydAacU1RqZWA@mail.gmail.com
>>
>> [2] http://paste.ubuntu.com/p/srQxwPQS9s/
>>
>
> I will submit a cleanup patch for RSI warning

Thanks, but Tobin was faster:

https://lkml.kernel.org/r/[email protected]

He just forgot to CC linux-wireless.

--
Kalle Valo