2014-10-07 10:27:36

by Janusz Dziedzic

Subject: [PATCH] ath10k: fix WMI scan command length

Fix WMI scan command length we setup when scan request.

This fix issue with 636 firmware when scan always failed
with message:

ath10k_pci 0000:02:00.0: wmi start scan
ath10k_pci 0000:02:00.0: wmi stop scan reqid 1 req_type 0 vdev/scan_id 0
ath10k_pci 0000:02:00.0: failed to stop wmi scan: -11
ath10k_pci 0000:02:00.0: failed to stop scan: -11
ath10k_pci 0000:02:00.0: failed to start hw scan: -110

Signed-off-by: Janusz Dziedzic <[email protected]>
---
drivers/net/wireless/ath/ath10k/wmi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c
index f65032f..d878fbe 100644
--- a/drivers/net/wireless/ath/ath10k/wmi.c
+++ b/drivers/net/wireless/ath/ath10k/wmi.c
@@ -3506,10 +3506,10 @@ int ath10k_wmi_start_scan(struct ath10k *ar,
return ret;

if (test_bit(ATH10K_FW_FEATURE_WMI_10X, ar->fw_features))
- len = sizeof(struct wmi_start_scan_cmd) +
+ len = sizeof(struct wmi_10x_start_scan_cmd) +
ath10k_wmi_start_scan_tlvs_len(arg);
else
- len = sizeof(struct wmi_10x_start_scan_cmd) +
+ len = sizeof(struct wmi_start_scan_cmd) +
ath10k_wmi_start_scan_tlvs_len(arg);

skb = ath10k_wmi_alloc_skb(ar, len);
--
1.9.1

2014-10-08 10:24:41

by Kalle Valo

Subject: Re: [PATCH] ath10k: fix WMI scan command length

Janusz Dziedzic <[email protected]> writes:

> Fix WMI scan command length we setup when scan request.
>
> This fix issue with 636 firmware when scan always failed
> with message:
>
> ath10k_pci 0000:02:00.0: wmi start scan
> ath10k_pci 0000:02:00.0: wmi stop scan reqid 1 req_type 0 vdev/scan_id 0
> ath10k_pci 0000:02:00.0: failed to stop wmi scan: -11
> ath10k_pci 0000:02:00.0: failed to stop scan: -11
> ath10k_pci 0000:02:00.0: failed to start hw scan: -110
>
> Signed-off-by: Janusz Dziedzic <[email protected]>

Thanks, applied.

--
Kalle Valo