2020-08-31 04:37:54

by Allen

Subject: [PATCH] wireless: rtlwifi/rtw88: fix build warning

Tasklet conversion patch introduced a build
warning in _rtl_usb_init_rx, this patch fixes the warning.

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Allen Pais <[email protected]>
---
drivers/net/wireless/realtek/rtlwifi/usb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/usb.c b/drivers/net/wireless/realtek/rtlwifi/usb.c
index 8740818e8..6aa4bd2f7 100644
--- a/drivers/net/wireless/realtek/rtlwifi/usb.c
+++ b/drivers/net/wireless/realtek/rtlwifi/usb.c
@@ -310,7 +310,8 @@ static int _rtl_usb_init_rx(struct ieee80211_hw *hw)
init_usb_anchor(&rtlusb->rx_cleanup_urbs);

skb_queue_head_init(&rtlusb->rx_queue);
- rtlusb->rx_work_tasklet.func = (void(*)(unsigned long))_rtl_rx_work;
+ rtlusb->rx_work_tasklet.func = (void(*))_rtl_rx_work;
+ rtlusb->rx_work_tasklet.data = (unsigned long)&rtlusb->rx_work_tasklet;

return 0;
}
--
2.25.1

2020-08-31 14:07:31

by Kalle Valo

Subject: Re: [PATCH] wireless: rtlwifi/rtw88: fix build warning

Allen Pais <[email protected]> writes:

> Tasklet conversion patch introduced a build
> warning in _rtl_usb_init_rx, this patch fixes the warning.
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Allen Pais <[email protected]>
> ---
> drivers/net/wireless/realtek/rtlwifi/usb.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

I'll change the title:

rtlwifi: fix build warning

And add:

Fixes: d3ccc14dfe95 ("rtlwifi/rtw88: convert tasklets to use new tasklet_setup() API")

--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2020-09-01 09:01:11

by Kalle Valo

Subject: Re: rtlwifi: fix build warning

Allen Pais <[email protected]> wrote:

> Tasklet conversion patch introduced a build
> warning in _rtl_usb_init_rx, this patch fixes the warning.
>
> Reported-by: kernel test robot <[email protected]>
> Fixes: d3ccc14dfe95 ("rtlwifi/rtw88: convert tasklets to use new tasklet_setup() API")
> Signed-off-by: Allen Pais <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

6b8c7574a5f8 rtlwifi: fix build warning

--
https://patchwork.kernel.org/patch/11745471/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches