2014-11-14 03:17:59

by Peter Oh

Subject: [PATCH] ath10k: fix mismatched wmi api call

Fix to use v10.2 wmi call for firmware v10.2.
It turned out that peer association function was using
v10.1 wmi call for v10.2 firmware during code review.

Signed-off-by: Peter Oh <[email protected]>
---
drivers/net/wireless/ath/ath10k/wmi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c
index ae746ce..f5d1081 100644
--- a/drivers/net/wireless/ath/ath10k/wmi.c
+++ b/drivers/net/wireless/ath/ath10k/wmi.c
@@ -4187,9 +4187,9 @@ int ath10k_wmi_peer_assoc(struct ath10k *ar,

if (test_bit(ATH10K_FW_FEATURE_WMI_10X, ar->fw_features)) {
if (test_bit(ATH10K_FW_FEATURE_WMI_10_2, ar->fw_features))
- ath10k_wmi_peer_assoc_fill_10_1(ar, skb->data, arg);
- else
ath10k_wmi_peer_assoc_fill_10_2(ar, skb->data, arg);
+ else
+ ath10k_wmi_peer_assoc_fill_10_1(ar, skb->data, arg);
} else {
ath10k_wmi_peer_assoc_fill_main(ar, skb->data, arg);
}
--
1.9.1

2014-11-20 11:18:03

by Kalle Valo

Subject: Re: [PATCH] ath10k: fix mismatched wmi api call

Peter Oh <[email protected]> writes:

> Fix to use v10.2 wmi call for firmware v10.2.
> It turned out that peer association function was using
> v10.1 wmi call for v10.2 firmware during code review.
>
> Signed-off-by: Peter Oh <[email protected]>

Thanks, applied.

(Actually I had applied this already on Nov 17 but forgot to reply.)

--
Kalle Valo