The firmware feature check introduced for multi-scheduled scan is also
failing for bcm4345 devices resulting in a firmware crash.
The reason for this crash has not yet been root cause so this patch avoids
the feature check for those device as a short-term fix.
Fixes: 9fe929aaace6 ("brcmfmac: add firmware feature detection for gscan feature")
Signed-off-by: Ian W MORRISON <[email protected]>
---
v2: Fixed tabs being replaced by spaces in patch submission
Tested on MINIX NEO Z83-4 and MINIX NEO Z83-4 Pro devices.
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c
index f1b60740e..53ae302 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c
@@ -159,7 +159,8 @@ void brcmf_feat_attach(struct brcmf_pub *drvr)
brcmf_feat_firmware_capabilities(ifp);
memset(&gscan_cfg, 0, sizeof(gscan_cfg));
- if (drvr->bus_if->chip != BRCM_CC_43430_CHIP_ID)
+ if (drvr->bus_if->chip != BRCM_CC_43430_CHIP_ID &&
+ drvr->bus_if->chip != BRCM_CC_4345_CHIP_ID)
brcmf_feat_iovar_data_set(ifp, BRCMF_FEAT_GSCAN,
"pfn_gscan_cfg",
&gscan_cfg, sizeof(gscan_cfg));
--
1.9.1
On 2 September 2017 at 06:04, Arend van Spriel
<[email protected]> wrote:
> On 31-08-17 00:51, Ian W MORRISON wrote:
>>
>> The firmware feature check introduced for multi-scheduled scan is also
>> failing for bcm4345 devices resulting in a firmware crash.
>> The reason for this crash has not yet been root cause so this patch avoids
>> the feature check for those device as a short-term fix.
>
>
> Thanks. This is one of the few devices that I actually do not have on my
> desk.
>
> Acked-by: Arend van Spriel <[email protected]>
>>
>> Fixes: 9fe929aaace6 ("brcmfmac: add firmware feature detection for gscan
>> feature")
>> Signed-off-by: Ian W MORRISON <[email protected]>
>> ---
>> v2: Fixed tabs being replaced by spaces in patch submission
>> Tested on MINIX NEO Z83-4 and MINIX NEO Z83-4 Pro devices.
>> ---
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
Thanks. This patch of course is required to fix the '4.13 REGRESSION'
for brcm4345 sdio wifi with 4.13-rc1 through 4.13-rc7 as v4.12.10 is
the last working release. If you want me to test anything specific on
this device let me know.
Ian W MORRISON <[email protected]> writes:
> On 2 September 2017 at 06:04, Arend van Spriel
> <[email protected]> wrote:
>> On 31-08-17 00:51, Ian W MORRISON wrote:
>>>
>>> The firmware feature check introduced for multi-scheduled scan is also
>>> failing for bcm4345 devices resulting in a firmware crash.
>>> The reason for this crash has not yet been root cause so this patch avoids
>>> the feature check for those device as a short-term fix.
>>
>>
>> Thanks. This is one of the few devices that I actually do not have on my
>> desk.
>>
>> Acked-by: Arend van Spriel <[email protected]>
>>>
>>> Fixes: 9fe929aaace6 ("brcmfmac: add firmware feature detection for gscan
>>> feature")
>>> Signed-off-by: Ian W MORRISON <[email protected]>
>>> ---
>>> v2: Fixed tabs being replaced by spaces in patch submission
>>> Tested on MINIX NEO Z83-4 and MINIX NEO Z83-4 Pro devices.
>>> ---
>>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c | 3 ++-
>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> Thanks. This patch of course is required to fix the '4.13 REGRESSION'
> for brcm4345 sdio wifi with 4.13-rc1 through 4.13-rc7 as v4.12.10 is
> the last working release. If you want me to test anything specific on
> this device let me know.
I'll queue this for 4.14. And add a stable tag so that I goes to 4.13
stable releases:
Cc: <[email protected]> # v4.13
--
Kalle Valo
On 31-08-17 00:51, Ian W MORRISON wrote:
> The firmware feature check introduced for multi-scheduled scan is also
> failing for bcm4345 devices resulting in a firmware crash.
> The reason for this crash has not yet been root cause so this patch avoids
> the feature check for those device as a short-term fix.
Thanks. This is one of the few devices that I actually do not have on my
desk.
Acked-by: Arend van Spriel <[email protected]>
> Fixes: 9fe929aaace6 ("brcmfmac: add firmware feature detection for gscan feature")
> Signed-off-by: Ian W MORRISON <[email protected]>
> ---
> v2: Fixed tabs being replaced by spaces in patch submission
> Tested on MINIX NEO Z83-4 and MINIX NEO Z83-4 Pro devices.
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
On 4 September 2017 at 23:01, Kalle Valo <[email protected]> wrote:
>
> I'll queue this for 4.14. And add a stable tag so that I goes to 4.13
> stable releases:
>
> Cc: <[email protected]> # v4.13
>
> --
> Kalle Valo
Thanks.
Ian W MORRISON <[email protected]> wrote:
> The firmware feature check introduced for multi-scheduled scan is also
> failing for bcm4345 devices resulting in a firmware crash.
> The reason for this crash has not yet been root cause so this patch avoids
> the feature check for those device as a short-term fix.
>
> Fixes: 9fe929aaace6 ("brcmfmac: add firmware feature detection for gscan feature")
> Cc: <[email protected]> # v4.13
> Signed-off-by: Ian W MORRISON <[email protected]>
> Acked-by: Arend van Spriel <[email protected]>
Patch applied to wireless-drivers.git, thanks.
f957dd3c8db2 brcmfmac: feature check for multi-scheduled scan fails on bcm4345 devices
--
https://patchwork.kernel.org/patch/9930929/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches