LinuxLists.cc - [PATCH] ssb: Silence warning for unknown backplane revision

2015-02-18 20:09:55

Subject: [PATCH] ssb: Silence warning for unknown backplane revision

When using a BCM4318 in a PCMCIA format, I get a startup message that the
device uses backplane revision 0xF000000. Next a WARNING is logged. Despite
the message, the device works fine, This patch silences the warning.

Cc: Rafał Miłecki <[email protected]>
Signed-off-by: Larry Finger <[email protected]>
---
drivers/ssb/main.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/ssb/main.c b/drivers/ssb/main.c
index 1e180c4..a48a743 100644
--- a/drivers/ssb/main.c
+++ b/drivers/ssb/main.c
@@ -1135,6 +1135,8 @@ static u32 ssb_tmslow_reject_bitmask(struct ssb_device *dev)
case SSB_IDLOW_SSBREV_25: /* TODO - find the proper REJECT bit */
case SSB_IDLOW_SSBREV_27: /* same here */
return SSB_TMSLOW_REJECT; /* this is a guess */
+ case SSB_IDLOW_SSBREV:
+ break;
default:
WARN(1, KERN_INFO "ssb: Backplane Revision 0x%.8X\n", rev);
}
--
2.1.4

2015-02-26 12:57:28

by Kalle Valo

[permalink] [raw]

Subject: Re: [PATCH] ssb: Silence warning for unknown backplane revision

Larry Finger <[email protected]> writes:

> When using a BCM4318 in a PCMCIA format, I get a startup message that the
> device uses backplane revision 0xF000000. Next a WARNING is logged. Despite
> the message, the device works fine, This patch silences the warning.
>
> Cc: Rafał Miłecki <[email protected]>
> Signed-off-by: Larry Finger <[email protected]>

Should this go to 4.0?

--
Kalle Valo

2015-02-26 16:06:54

by Larry Finger

[permalink] [raw]

Subject: Re: [PATCH] ssb: Silence warning for unknown backplane revision

On 02/26/2015 06:57 AM, Kalle Valo wrote:
> Larry Finger <[email protected]> writes:
>
>> When using a BCM4318 in a PCMCIA format, I get a startup message that the
>> device uses backplane revision 0xF000000. Next a WARNING is logged. Despite
>> the message, the device works fine, This patch silences the warning.
>>
>> Cc: Rafał Miłecki <[email protected]>
>> Signed-off-by: Larry Finger <[email protected]>
>
> Should this go to 4.0?

As this one merely stops log spamming, sending it through NEXT is OK.

Larry

2015-03-03 13:54:43

by Kalle Valo

[permalink] [raw]