2013-12-16 16:28:01

by Krishna Chaitanya

Subject: [RFC] crda: Fix the linking order to avoid compilation error

While linking the crda.o and libreg.so, first put crda.o
and then -lreg. This fixed the below error:

# make
GEN keys-gcrypt.c
Trusted pubkeys: pubkeys/linville.key.pub.pem
CC libreg.so
CC crda.o
LD crda
crda.o: In function `main':
crda/crda.c:196: undefined reference to `reglib_get_rd_alpha2'
collect2: ld returned 1 exit status
make: *** [crda] Error 1

Note: This still doesn't fix the below error (will send another mail)

CHK /usr/lib/crda/regulatory.bin
Database signature verification failed.
Invalid or empty regulatory file, note: a binary regulatory file should be used.
make: *** [verify] Error 234

Signed-off-by: Chaitanya T K <[email protected]>
---
Makefile | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/Makefile b/Makefile
index 4a351c6..0b2f0d7 100644
--- a/Makefile
+++ b/Makefile
@@ -28,10 +28,11 @@ RUNTIME_PUBKEY_DIR?=/etc/wireless-regdb/pubkeys
CFLAGS += -O2 -fpic
CFLAGS += -std=gnu99 -Wall -Werror -pedantic
CFLAGS += -Wall -g
-LDLIBS += -lm
LDLIBREG += -lreg
+LDLIBS += $(LDLIBREG)
+LDLIBS += -lm
LIBREG += libreg.so
-LDFLAGS += -L ./ $(LDLIBREG)
+LDFLAGS += -L ./

all: all_noverify verify

2014-02-19 21:55:50

by Luis Chamberlain

Subject: Re: [RFC] crda: Fix the linking order to avoid compilation error

On Mon, Dec 16, 2013 at 8:27 AM, Krishna Chaitanya
<[email protected]> wrote:
> While linking the crda.o and libreg.so, first put crda.o
> and then -lreg. This fixed the below error:
>
> # make
> GEN keys-gcrypt.c
> Trusted pubkeys: pubkeys/linville.key.pub.pem
> CC libreg.so
> CC crda.o
> LD crda
> crda.o: In function `main':
> crda/crda.c:196: undefined reference to `reglib_get_rd_alpha2'
> collect2: ld returned 1 exit status
> make: *** [crda] Error 1
>
> Note: This still doesn't fix the below error (will send another mail)
>
> CHK /usr/lib/crda/regulatory.bin
> Database signature verification failed.
> Invalid or empty regulatory file, note: a binary regulatory file should be used.
> make: *** [verify] Error 234
>
> Signed-off-by: Chaitanya T K <[email protected]>

Applied and pushed, thanks!

Luis

2014-02-14 09:05:57

by Kalle Valo

Subject: Re: [RFC] crda: Fix the linking order to avoid compilation error

Krishna Chaitanya <[email protected]> writes:

> While linking the crda.o and libreg.so, first put crda.o
> and then -lreg. This fixed the below error:
>
> # make
> GEN keys-gcrypt.c
> Trusted pubkeys: pubkeys/linville.key.pub.pem
> CC libreg.so
> CC crda.o
> LD crda
> crda.o: In function `main':
> crda/crda.c:196: undefined reference to `reglib_get_rd_alpha2'
> collect2: ld returned 1 exit status
> make: *** [crda] Error 1

[...]

> Signed-off-by: Chaitanya T K <[email protected]>
> ---
> Makefile | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 4a351c6..0b2f0d7 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -28,10 +28,11 @@ RUNTIME_PUBKEY_DIR?=/etc/wireless-regdb/pubkeys
> CFLAGS += -O2 -fpic
> CFLAGS += -std=gnu99 -Wall -Werror -pedantic
> CFLAGS += -Wall -g
> -LDLIBS += -lm
> LDLIBREG += -lreg
> +LDLIBS += $(LDLIBREG)
> +LDLIBS += -lm
> LIBREG += libreg.so
> -LDFLAGS += -L ./ $(LDLIBREG)
> +LDFLAGS += -L ./
>
> all: all_noverify verify

Without this patch crda didn't compile on my Ubuntu 12.04 box. IMHO this
should be applied.

--
Kalle Valo