2018-03-27 10:54:27

by Izzy Kulbe

[permalink] [raw]
Subject: Re: [PATCH] iwlwifi: add device ID for Rivet Networks Killer Wireless-AC 1550

nvm the last message, attached the wrong file using the 9270 instead of the 9260 firmware, which obviously wouldn't work. Here's the working patch:


Add support for Rivet Networks Killer Wireless-AC 1550 chipset,
which is using the Intel Wireless-AC 9260 chip

Signed-off-by: Izzy Kulbe <[email protected]>

---
drivers/net/wireless/intel/iwlwifi/pcie/drv.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c /drivers/net/wireless/intel/iwlwifi/pcie/drv.c
--- a/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
+++ b/drivers/net/wireless/intel/iwlwifi/pcie/drv.c
@@ -543,6 +543,7 @@ static const struct pci_device_id iwl_hw_card_ids[]
= {
{IWL_PCI_DEVICE(0x2526, 0x1210, iwl9260_2ac_cfg)},
{IWL_PCI_DEVICE(0x2526, 0x1410, iwl9270_2ac_cfg)},
{IWL_PCI_DEVICE(0x2526, 0x1420, iwl9460_2ac_cfg_soc)},
+ {IWL_PCI_DEVICE(0x2526, 0x1550, iwl9260_2ac_cfg)},
{IWL_PCI_DEVICE(0x2526, 0x1610, iwl9270_2ac_cfg)},
{IWL_PCI_DEVICE(0x2526, 0x4010, iwl9260_2ac_cfg)},
{IWL_PCI_DEVICE(0x2526, 0x4030, iwl9560_2ac_cfg)},


2018-03-27 11:48:06

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] iwlwifi: add device ID for Rivet Networks Killer Wireless-AC 1550

Izzy Kulbe <[email protected]> writes:

> nvm the last message, attached the wrong file using the 9270 instead of the 9260 firmware, which obviously wouldn't work. Here's the working patch:
>
>
> Add support for Rivet Networks Killer Wireless-AC 1550 chipset,
> which is using the Intel Wireless-AC 9260 chip
>
> Signed-off-by: Izzy Kulbe <[email protected]>
>
> ---

You should put the comment "nvm the last message..." under the "---"
line so that git-am can ignore it.

--
Kalle Valo

2018-03-27 12:03:38

by Izzy Kulbe

[permalink] [raw]
Subject: Re: [PATCH] iwlwifi: add device ID for Rivet Networks Killer Wireless-AC 1550

On Tue, 2018-03-27 at 14:48 +0300, Kalle Valo wrote:
> Izzy Kulbe <[email protected]> writes:
>
> > nvm the last message, attached the wrong file using the 9270 instead of the 9260 firmware, which obviously wouldn't work. Here's the working patch:
> >
> >
> > Add support for Rivet Networks Killer Wireless-AC 1550 chipset,
> > which is using the Intel Wireless-AC 9260 chip
> >
> > Signed-off-by: Izzy Kulbe <[email protected]>
> >
> > ---
>
> You should put the comment "nvm the last message..." under the "---"
> line so that git-am can ignore it.

Sorry, still new to the whole process. should i just resend
that message with the proper order?

2018-03-27 14:09:21

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] iwlwifi: add device ID for Rivet Networks Killer Wireless-AC 1550

Izzy Kulbe <[email protected]> writes:

> On Tue, 2018-03-27 at 14:48 +0300, Kalle Valo wrote:
>> Izzy Kulbe <[email protected]> writes:
>>
>> > nvm the last message, attached the wrong file using the 9270
>> > instead of the 9260 firmware, which obviously wouldn't work.
>> > Here's the working patch:
>> >
>> >
>> > Add support for Rivet Networks Killer Wireless-AC 1550 chipset,
>> > which is using the Intel Wireless-AC 9260 chip
>> >
>> > Signed-off-by: Izzy Kulbe <[email protected]>
>> >
>> > ---
>>
>> You should put the comment "nvm the last message..." under the "---"
>> line so that git-am can ignore it.
>
> Sorry, still new to the whole process. should i just resend
> that message with the proper order?

Luca already replied, so don't resend yet. But please do read the
documentation, it should help you with the basics and have pointers to
other docs:

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

--
Kalle Valo