2011-12-01 11:13:50

by Pontus Fuchs

Subject: [PATCH] wl12xx: Restore testmode ABI

Commit 80900d0140a7648587982c8f299830e900e49165 accidently broke
the ABI for testmode commands. Restore the ABI again.

Signed-off-by: Pontus Fuchs <[email protected]>
Cc: [email protected]
---
drivers/net/wireless/wl12xx/testmode.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/wl12xx/testmode.c b/drivers/net/wireless/wl12xx/testmode.c
index 61fff45..5b3f781 100644
--- a/drivers/net/wireless/wl12xx/testmode.c
+++ b/drivers/net/wireless/wl12xx/testmode.c
@@ -37,6 +37,7 @@ enum wl1271_tm_commands {
WL1271_TM_CMD_TEST,
WL1271_TM_CMD_INTERROGATE,
WL1271_TM_CMD_CONFIGURE,
+ WL1271_TM_CMD_NVS_PUSH, /* Not in use. Keep to not break ABI */
WL1271_TM_CMD_SET_PLT_MODE,
WL1271_TM_CMD_RECOVER,

--
1.7.5.4

2011-12-15 07:37:35

by Luciano Coelho

Subject: Re: [PATCH] wl12xx: Restore testmode ABI

Hi Kalle,

On Thu, 2011-12-01 at 13:23 +0200, Kalle Valo wrote:
> Pontus Fuchs <[email protected]> writes:
>
> > Commit 80900d0140a7648587982c8f299830e900e49165 accidently broke
> > the ABI for testmode commands. Restore the ABI again.
> >
>
> [...]
>
> > --- a/drivers/net/wireless/wl12xx/testmode.c
> > +++ b/drivers/net/wireless/wl12xx/testmode.c
> > @@ -37,6 +37,7 @@ enum wl1271_tm_commands {
> > WL1271_TM_CMD_TEST,
> > WL1271_TM_CMD_INTERROGATE,
> > WL1271_TM_CMD_CONFIGURE,
> > + WL1271_TM_CMD_NVS_PUSH, /* Not in use. Keep to not break ABI */
>
> Better to call it WL1271_TM_CMD_UNUSED1, or something like that, so that
> it really stays unused.

As we discussed briefly on IRC, I think it's a better idea to keep it as
is. If anyone still uses it (despite the comment saying it's not in
use), we will return -EOPNOTSUPP.

--
Cheers,
Luca.

2011-12-15 08:53:31

by Luciano Coelho

Subject: Re: [PATCH] wl12xx: Restore testmode ABI

On Thu, 2011-12-01 at 12:13 +0100, Pontus Fuchs wrote:
> Commit 80900d0140a7648587982c8f299830e900e49165 accidently broke
> the ABI for testmode commands. Restore the ABI again.
>
> Signed-off-by: Pontus Fuchs <[email protected]>
> Cc: [email protected]
> ---

Applied, thanks!

--
Cheers,
Luca.

2011-12-01 11:23:47

by Kalle Valo

Subject: Re: [PATCH] wl12xx: Restore testmode ABI

Pontus Fuchs <[email protected]> writes:

> Commit 80900d0140a7648587982c8f299830e900e49165 accidently broke
> the ABI for testmode commands. Restore the ABI again.
>

[...]

> --- a/drivers/net/wireless/wl12xx/testmode.c
> +++ b/drivers/net/wireless/wl12xx/testmode.c
> @@ -37,6 +37,7 @@ enum wl1271_tm_commands {
> WL1271_TM_CMD_TEST,
> WL1271_TM_CMD_INTERROGATE,
> WL1271_TM_CMD_CONFIGURE,
> + WL1271_TM_CMD_NVS_PUSH, /* Not in use. Keep to not break ABI */

Better to call it WL1271_TM_CMD_UNUSED1, or something like that, so that
it really stays unused.

--
Kalle Valo