2023-08-14 14:56:44

by Toke Høiland-Jørgensen

[permalink] [raw]
Subject: Re: [PATCH] wireless: ath: remove unused-but-set parameter

Arnd Bergmann <[email protected]> writes:

> From: Arnd Bergmann <[email protected]>
>
> This has never been used since the driver was merged, but it now causes
> a W=1 warning in recent clang versions
>
> drivers/net/wireless/ath/ath9k/main.c:1566:21: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter]
> drivers/net/wireless/ath/ath9k/htc_drv_main.c:1258:25: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter]
> drivers/net/wireless/ath/ath5k/mac80211-ops.c:367:62: error: parameter 'changed_flags' set but not used [-Werror,-Wunused-but-set-parameter]
>
> Remove the bit manipulation on the otherwise unused parameter.
>
> Signed-off-by: Arnd Bergmann <[email protected]>

For ath9k:
Acked-by: Toke Høiland-Jørgensen <[email protected]>