2012-03-08 14:03:23

by Johannes Berg

Subject: [PATCH 4/6] mac80211: remove spurious BSSID change flag

From: Johannes Berg <[email protected]>

The BSSID has been set a lot earlier already and
didn't change again in ieee80211_set_associated().

Signed-off-by: Johannes Berg <[email protected]>
---
net/mac80211/mlme.c | 3 ---
1 file changed, 3 deletions(-)

--- a/net/mac80211/mlme.c 2012-03-08 13:55:16.000000000 +0100
+++ b/net/mac80211/mlme.c 2012-03-08 13:55:22.000000000 +0100
@@ -1351,9 +1351,6 @@ static void ieee80211_set_associated(str
*/
bss_info_changed |= BSS_CHANGED_BASIC_RATES;

- /* And the BSSID changed - we're associated now */
- bss_info_changed |= BSS_CHANGED_BSSID;
-
/* Tell the driver to monitor connection quality (if supported) */
if (sdata->vif.driver_flags & IEEE80211_VIF_SUPPORTS_CQM_RSSI &&
bss_conf->cqm_rssi_thold)

2012-03-08 16:13:42

by Johannes Berg

Subject: Re: [PATCH 4/6] mac80211: remove spurious BSSID change flag

> The BSSID has been set a lot earlier already and
> didn't change again in ieee80211_set_associated().
>
> Signed-off-by: Johannes Berg <[email protected]>
> ---
> net/mac80211/mlme.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> --- a/net/mac80211/mlme.c 2012-03-08 13:55:16.000000000 +0100
> +++ b/net/mac80211/mlme.c 2012-03-08 13:55:22.000000000 +0100
> @@ -1351,9 +1351,6 @@ static void ieee80211_set_associated(str
> */
> bss_info_changed |= BSS_CHANGED_BASIC_RATES;
>
> - /* And the BSSID changed - we're associated now */
> - bss_info_changed |= BSS_CHANGED_BSSID;

Sujith tells me that this will break ath9k -- Rajkumar, can you take a
look at this? Before your commit 99e4d43ad5ff5778f92ee3bc40a29a ath9k
did listen to BSS_CHANGED_ASSOC -- it seems like it should again?

johannes

2012-03-09 23:41:15

by Rajkumar Manoharan

Subject: RE: [PATCH 4/6] mac80211: remove spurious BSSID change flag

>> The BSSID has been set a lot earlier already and
>> didn't change again in ieee80211_set_associated().
>>
>> Signed-off-by: Johannes Berg <[email protected]>
>> ---
>> net/mac80211/mlme.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> --- a/net/mac80211/mlme.c 2012-03-08 13:55:16.000000000 +0100
>> +++ b/net/mac80211/mlme.c 2012-03-08 13:55:22.000000000 +0100
>> @@ -1351,9 +1351,6 @@ static void ieee80211_set_associated(str
>> */
>> bss_info_changed |= BSS_CHANGED_BASIC_RATES;
>>
>> - /* And the BSSID changed - we're associated now */
>> - bss_info_changed |= BSS_CHANGED_BSSID;
>
> Sujith tells me that this will break ath9k -- Rajkumar, can you take a
> look at this? Before your commit 99e4d43ad5ff5778f92ee3bc40a29a ath9k
> did listen to BSS_CHANGED_ASSOC -- it seems like it should again?

Sorry for the late reply. I changed back to ASSOC to configure bss info and verified w/ your changes.

-Rajkumar