2017-07-31 11:14:49

by Souptick Joarder

Subject: [PATCH v4] rtlwifi: Replace hardcode value with macro

In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval
and hw->max_rate_tries are replaced by macro.

Signed-off-by: Souptick Joarder <[email protected]>
---
drivers/net/wireless/realtek/rtlwifi/base.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c
index f45d093..52f2d0b 100644
--- a/drivers/net/wireless/realtek/rtlwifi/base.c
+++ b/drivers/net/wireless/realtek/rtlwifi/base.c
@@ -422,7 +422,6 @@ static void _rtl_init_mac80211(struct ieee80211_hw *hw)
hw->extra_tx_headroom = RTL_TX_HEADER_SIZE;

/* TODO: Correct this value for our hw */
- /* defined these hard code values */
hw->max_listen_interval = MAX_LISTEN_INTERVAL;
hw->max_rate_tries = MAX_RATE_TRIES;
/* hw->max_rates = 1; */
--
1.9.1

2017-07-31 14:18:53

by Larry Finger

Subject: Re: [PATCH v4] rtlwifi: Replace hardcode value with macro

On 07/31/2017 06:14 AM, Souptick Joarder wrote:
> In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval
> and hw->max_rate_tries are replaced by macro.

That is NOT what your patch does. It only removes a comment! Granted, that
comment is useless and should come out, but your commit message must be a little
more accurate.

NACK.

Larry

>
> Signed-off-by: Souptick Joarder <[email protected]>
> ---
> drivers/net/wireless/realtek/rtlwifi/base.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/base.c b/drivers/net/wireless/realtek/rtlwifi/base.c
> index f45d093..52f2d0b 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/base.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/base.c
> @@ -422,7 +422,6 @@ static void _rtl_init_mac80211(struct ieee80211_hw *hw)
> hw->extra_tx_headroom = RTL_TX_HEADER_SIZE;
>
> /* TODO: Correct this value for our hw */
> - /* defined these hard code values */
> hw->max_listen_interval = MAX_LISTEN_INTERVAL;
> hw->max_rate_tries = MAX_RATE_TRIES;
> /* hw->max_rates = 1; */
> --
> 1.9.1
>
>

2017-08-02 09:21:20

by Kalle Valo

Subject: Re: [PATCH v4] rtlwifi: Replace hardcode value with macro

Larry Finger <[email protected]> writes:

> On 07/31/2017 06:14 AM, Souptick Joarder wrote:
>> In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval
>> and hw->max_rate_tries are replaced by macro.
>
> That is NOT what your patch does. It only removes a comment! Granted,
> that comment is useless and should come out, but your commit message
> must be a little more accurate.

Actually the patch does not even apply, I suspect that Souptick
incorrectly used v3 of his patch as the baseline for v4. Instead this v4
should be folded with v3.

--
Kalle Valo